Re: [PATCH v3 1/2] dt-bindings: rtc: Add property for Raspberry Pi 5 RTC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: constraint bypass due to missing scalar type on -millivolt property
--

commit a0ac03cb8b207820432d22540ca183fbaafbeb38
Author: Sander Speetjens <sander.speetjens@gmail.com>

dt-bindings: rtc: Add property for Raspberry Pi 5 RTC
    
This commit adds the trickle-voltage-millivolt property to the
raspberrypi,bcm2835-firmware binding for the Raspberry Pi 5 RTC. It also
introduces minimum and maximum voltage constraints for this property.

> diff --git a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml
> index 983ea80eaec97..dc71fd57834e8 100644
> --- a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml
> +++ b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml
> @@ -133,6 +133,11 @@ properties:
>      required:
>        - compatible
>  
> +  trickle-voltage-millivolt:
> +    $ref: /schemas/rtc/rtc.yaml#/properties/trickle-voltage-millivolt
> +    minimum: 1300
> +    maximum: 5000

[Severity: Medium]
Are these constraints applied effectively here?

Since dtschema's property-units.yaml assigns a default array type to
properties ending in -millivolt, applying minimum and maximum constraints
here without explicitly redefining the property as a scalar type (e.g.,
via $ref: /schemas/types.yaml#/definitions/uint32) can cause JSON Schema
to silently bypass these constraints.

Could device trees with out-of-bounds voltages pass validation when
dt_binding_check evaluates the constraints against the default array type?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260917135841.841680-1-sander.speetjens@gmail.com?part=1