From: sashiko-bot@kernel.org
To: "Geert Uytterhoeven" <geert@linux-m68k.org>
Cc: wsa+renesas@sang-engineering.com, linux-serial@vger.kernel.org,
devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH] dt-bindings: serial: renesas,hscif: Increase number of DMA channels to 6
Date: Thu, 17 Sep 2026 14:14:22 +0000 [thread overview]
Message-ID: <20260917141422.D34001F000FF@smtp.kernel.org> (raw)
In-Reply-To: <a08834717c1df2c8974cb0b8300a20cc33c426fa.1789653869.git.geert@linux-m68k.org>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: serial: renesas,hscif: global DMA maxItems relaxation permits invalid configurations
--
commit 5201605fb4ecc80faa0e010c992a164bfb0972af
Author: Geert Uytterhoeven <geert@linux-m68k.org>
dt-bindings: serial: renesas,hscif: Increase number of DMA channels to 6
This commit increases the maximum number of DMA channels for HSCIF serial
interfaces from 4 to 6. This change is intended to support the R-Car X5H
hardware, which has interfaces wired to three DMACs.
> diff --git a/Documentation/devicetree/bindings/serial/renesas,hscif.yaml b/Documentation/devicetree/bindings/serial/renesas,hscif.yaml
> index 4b3f98a46cd9d..409cab32de3d8 100644
> --- a/Documentation/devicetree/bindings/serial/renesas,hscif.yaml
> +++ b/Documentation/devicetree/bindings/serial/renesas,hscif.yaml
> @@ -97,14 +97,14 @@ properties:
>
> dmas:
> minItems: 2
> - maxItems: 4
> + maxItems: 6
[Severity: Medium]
Does this global change to maxItems permit invalid configurations for older
hardware generations?
By globally increasing the maximum allowed items from 4 to 6 to support Gen5
hardware, the schema will now incorrectly pass validation for Gen1-Gen4 nodes
that specify 5 or 6 DMA channels, despite those SoCs only supporting up to 4.
Should an if:then conditional block be used instead to enforce maxItems: 4
for earlier generations, or to allow 6 only for Gen5 hardware?
> description:
> Must contain a list of pairs of references to DMA specifiers, one for
> transmission, and one for reception.
>
> dma-names:
> minItems: 2
> - maxItems: 4
> + maxItems: 6
[Severity: Medium]
Does this also weaken the schema validation for dma-names on older hardware
generations in the same way?
--
Sashiko AI review · https://sashiko.dev/#/patchset/a08834717c1df2c8974cb0b8300a20cc33c426fa.1789653869.git.geert@linux-m68k.org?part=1
next prev parent reply other threads:[~2026-09-17 14:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 14:06 [PATCH] dt-bindings: serial: renesas,hscif: Increase number of DMA channels to 6 Geert Uytterhoeven
2026-09-17 14:14 ` sashiko-bot [this message]
2026-09-17 16:27 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260917141422.D34001F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-serial@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.