From: Arnd Bergmann via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <chao@kernel.org>,
Jianan Huang <jnhuang95@gmail.com>
Cc: Kelvin Zhang <zhangxp1998@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
Eric Biggers <ebiggers@kernel.org>,
Daeho Jeong <daehojeong@google.com>
Subject: [f2fs-dev] [PATCH] f2fs: quota: fix unused-label warning
Date: Thu, 17 Sep 2026 16:21:42 +0200 [thread overview]
Message-ID: <20260917142222.1591270-1-arnd@kernel.org> (raw)
From: Arnd Bergmann <arnd@arndb.de>
The newly added label causes a warning when QUOTA is turned off:
fs/f2fs/super.c: In function '__f2fs_remount':
fs/f2fs/super.c:3142:1: error: label 'restore_holder' defined but not used [-Werror=unused-label]
3142 | restore_holder:
| ^~~~~~~~~~~~~~
Fixes: 3f140a60c92a ("f2fs: quota: fix stale lock holder on remount failure")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
fs/f2fs/super.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 6a2f09c61dcd..8358cdefa859 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -3139,7 +3139,9 @@ static int __f2fs_remount(struct fs_context *fc, struct super_block *sb)
sbi->mount_opt = org_mount_opt;
sb->s_flags = old_sb_flags;
+#ifdef CONFIG_QUOTA
restore_holder:
+#endif
sbi->umount_lock_holder = NULL;
return err;
}
--
2.53.0
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next reply other threads:[~2026-09-17 14:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 14:21 Arnd Bergmann via Linux-f2fs-devel [this message]
2026-09-23 18:38 ` [f2fs-dev] [PATCH] f2fs: quota: fix unused-label warning Randy Dunlap
2026-09-30 8:01 ` Chao Yu via Linux-f2fs-devel
2026-09-30 17:20 ` patchwork-bot+f2fs--- via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260917142222.1591270-1-arnd@kernel.org \
--to=linux-f2fs-devel@lists.sourceforge.net \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=chao@kernel.org \
--cc=daehojeong@google.com \
--cc=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=jnhuang95@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zhangxp1998@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.