From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19AD84D7D4C; Thu, 17 Sep 2026 15:26:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789658806; cv=none; b=a1dN6THHNIn3figO1V8zPenO/Qg7NYZwt8gf4tfdpTMn3EINnH2BN5n7Wj1C97tE5Z83wlbryB/qWRK3LOs6QHqWd0wF/EoRqPaIGFNL1xzTKEDG7h10XkqY3/GPKnlY5MHvsA67XPvN3qT1Be7MJPSHIZz+50mcaHiohzyWjqQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789658806; c=relaxed/simple; bh=eCF/6hp9jYikb+yr1QMtXPT3qfeRzyY1qhG5G2gsa+A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oHAlVPMwsPYoMJ2WCSGNzO9ORHEnvJwf0KWBxoIO79cI5WcHhMQ0gW4Vuqz8W2Ll3tKftzlIWsVT9IG0qN8WMjYy3BWxfFsSuVcY3mjHLm5fc0hOU88UJ/Pjt+iWtIou82BOt7bgaCt7/OJUY5LHsSvK25UwFznYrdmKXdsjB10= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Jzc083Fn; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Jzc083Fn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39C841F00898; Thu, 17 Sep 2026 15:26:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789658793; bh=cn34fobJ2YBGvhoQ6HaATbcS72t8+Jp7ybRQKo9C1mQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Jzc083FnvQGDAkXGHSaiebXb1tk6h3QQ9h1l1tufU1oa69rVdBmIKn0/sM9U+Ry9P J+dfhILh8aJeKlH9QmtGpLaTp8ItOcKeYR/9pyKHg0/MIn3oY2svi/6aJORMwuAX8K MfTA0cyZUOueanVjwDPSkJkAu1BEO/WN0WTIzomY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jad Keskes , "Borislav Petkov (AMD)" , Sasha Levin Subject: [PATCH 7.2 011/733] EDAC/device_sysfs: Use kstrtouint() for poll_msec to prevent truncation Date: Thu, 17 Sep 2026 16:05:19 +0100 Message-ID: <20260917151350.928579419@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260917151350.597953846@linuxfoundation.org> References: <20260917151350.597953846@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.2-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jad Keskes [ Upstream commit 66cc9dec919dd63d8e4b3d386f7aed3ae684e645 ] The poll_msec sysfs store file uses simple_strtoul() which accepts an unsigned long, but the target field (poll_msec) is unsigned int. On 64-bit systems, a value > UINT_MAX is silently truncated when stored. Fix the mismatch by using kstrtouint() instead. This rejects values larger than UINT_MAX at parse time, making truncation impossible. Also add a check for value < 1 to reject the 0-delay case, which would cause the poll work to spin without delay and consume 100% CPU. Fixes: e27e3dac6517 ("drivers/edac: add edac_device class") Signed-off-by: Jad Keskes Signed-off-by: Borislav Petkov (AMD) Link: https://patch.msgid.link/20260730145549.148229-1-inasj268@gmail.com Signed-off-by: Sasha Levin --- drivers/edac/edac_device_sysfs.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/edac/edac_device_sysfs.c b/drivers/edac/edac_device_sysfs.c index b1c2717cd0237..6995ce039db97 100644 --- a/drivers/edac/edac_device_sysfs.c +++ b/drivers/edac/edac_device_sysfs.c @@ -88,14 +88,21 @@ static ssize_t edac_device_ctl_poll_msec_store(struct edac_device_ctl_info *ctl_info, const char *data, size_t count) { - unsigned long value; + unsigned int value; + int ret; /* get the value and enforce that it is non-zero, must be at least * one millisecond for the delay period, between scans * Then cancel last outstanding delay for the work request * and set a new one. */ - value = simple_strtoul(data, NULL, 0); + ret = kstrtouint(data, 0, &value); + if (ret < 0) + return ret; + + if (value < 1) + return -EINVAL; + edac_device_reset_delay_period(ctl_info, value); return count; -- 2.53.0