From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87AA04E73C7; Thu, 17 Sep 2026 15:49:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789660164; cv=none; b=kOYriGbaphAIN4+FE/LwSfE/kSCfp2G/H7To8V6G0tYv3V94fryNEYZRruvw0pINjMK0L1/s3dBdZ7oQuX6xBy4mhF8wHBXEvgr8d3CmSYRPMi0YyQMtxhFcSfdtGDOfv7yTqei6pMaid53z54cCu8ZRipv+MFKK2A0pLMXiL7E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789660164; c=relaxed/simple; bh=g310+1E7S71BEv/qyjbVRYsh3PAImFrKOwrSCkOSdWI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XJKbrsWNWGCN0ysL2pQfdDt582k8z18NAmoF4BL+csli8lUHz3a5RlfWsdOYSOZ0NqaxZGVBjW8zs6D9oiyZUzTzPDehJImP7irITZ1QgA97Q5daytcWw821+78dCvPqjyfruT0DC4btcFCWT0pZgFB3HzgOlBBQBGp/a8tK9cI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=L90yt5q+; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="L90yt5q+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5EBD61F000FF; Thu, 17 Sep 2026 15:49:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789660159; bh=8zLVM6V2vS1oyhBsxl6yEEvKB1ou3bapeOdrjOa4GO0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=L90yt5q+dG9+QQCy4JAIXh046NYEvUDd12txHePcXKMv+bV8GPm1lExluzirCPnA/ f/5ATzzOnlRr3UqRFUMeCfwWbqG5fQK6e8gQvDQ0XHmsdnk98efh6nqNmlJjtB6Ra8 y331QT0WUmQCbdIFF2M+8xw5S3jDv56UigZvdr+o= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable , "Ritesh Harjani (IBM)" , Shivaprasad G Bhat , Amit Machhiwal , Madhavan Srinivasan Subject: [PATCH 7.2 451/733] powerpc/eeh: Fix recursive locking on devices without EEH sensitive driver Date: Thu, 17 Sep 2026 16:12:39 +0100 Message-ID: <20260917151403.144191562@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260917151350.597953846@linuxfoundation.org> References: <20260917151350.597953846@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.2-stable review patch. If anyone has any objections, please let me know. ------------------ From: Shivaprasad G Bhat commit c5e68706527968282e49de205cc2b935823cb88a upstream. The commit 1010b4c012b0 ("powerpc/eeh: Make EEH driver device hotplug safe") refactored the EEH code such that the pci_rescan_remove_lock is held at the beginning of eeh_handle_normal_event() and the eeh_reset_device() is called with that lock being held. Looks like the commit missed to remove the existing lock/unlock inside eeh_rmv_device() which is no longer necessary. This is causing the eehd to hang on the lock which it actually holds when that code path is taken. [<0>] 0xc00000011c78f870 [<0>] __switch_to+0xfc/0x1a0 [<0>] pci_lock_rescan_remove+0x30/0x44 [<0>] eeh_rmv_device+0x290/0x2e0 [<0>] eeh_pe_dev_traverse+0x80/0x130 [<0>] eeh_reset_device+0xcc/0x23c [<0>] eeh_handle_normal_event+0x830/0xa80 [<0>] eeh_event_handler+0xf8/0x190 [<0>] kthread+0x194/0x1b0 [<0>] start_kernel_thread+0x14/0x18 The issue is seen for cases where the errors are detected on the PHB directly AND|OR for devices where the driver error_detected() returns PCI_ERS_RESULT_NEED_RESET, and driver being not EEH sensitive(i.e no error handlers like slot_reset(), resume() etc defined). Fixes: 1010b4c012b0 ("powerpc/eeh: Make EEH driver device hotplug safe") Cc: stable Reviewed-by: Ritesh Harjani (IBM) Signed-off-by: Shivaprasad G Bhat Reviewed-by: Amit Machhiwal Signed-off-by: Madhavan Srinivasan Link: https://patch.msgid.link/178404937381.913.2759874335293830160.stgit@linux.ibm.com Signed-off-by: Greg Kroah-Hartman --- arch/powerpc/kernel/eeh_driver.c | 2 -- 1 file changed, 2 deletions(-) --- a/arch/powerpc/kernel/eeh_driver.c +++ b/arch/powerpc/kernel/eeh_driver.c @@ -533,9 +533,7 @@ static void eeh_rmv_device(struct eeh_de if (rmv_data) list_add(&edev->rmv_entry, &rmv_data->removed_vf_list); } else { - pci_lock_rescan_remove(); pci_stop_and_remove_bus_device(dev); - pci_unlock_rescan_remove(); } }