From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 749CC4E73A7; Thu, 17 Sep 2026 15:53:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789660436; cv=none; b=UAAs4GLxf/cJExMjS6FaeGsEKe9CYVQM2gbisAqxbxqMysj0PlZ5LaIqSmFIQqGz8Ot0QpJ7m2T/kAwz5cfc+xYC9mO7zlbPbt7ppEffbYISEEsRp/PoOjtMecz1ERREIlX700RCcu1smCA1qD1gwndJmY5PkHqtjh7+0q86bjU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789660436; c=relaxed/simple; bh=b4eL5bsFoi3CSuAU/BKdcT9q/guE3TXbgPOyhUpxluM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kCGjSPMeWWsW05X6Jq9Zne9MXz1fsvsD5ZDFoEcKTtLO81X7vwLm4C0ac1eQ1YFpRq3FiYVXDvT+oRfmceorxchWUFdLHZjDBLQedk4Jl4EArWVeeIhAw6F9HOEqxo2/zBV+imwagLb5rJv/YakSBGwZAmrdg/2sygNy3MoaYII= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=cjiDsNRR; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="cjiDsNRR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CAB211F00893; Thu, 17 Sep 2026 15:53:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789660434; bh=YIJ9lUR7MI1rMCm7/uBmem/vizUXAWxOwrmz4OlwYYU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=cjiDsNRRoS51ZM1YnNuP7qLt4TV9CgLXb6XOXZmy3Sk4R9Ulkjg/t1otO2dKYiA/r KIxlB5W5Ilf7UgLLcsZhqzLw5krKhWywGXvgTeCYb4NUv4r+EzKdBxh75q5NU5wjM3 yk7lu+MgQvb9I75j4F9ZRpUlmErTjeT/3pamZRhI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Fan Wu , Guenter Roeck Subject: [PATCH 7.2 592/733] hwmon: (gpio-fan) Fix use-after-free in alarm work Date: Thu, 17 Sep 2026 16:15:00 +0100 Message-ID: <20260917151407.193311198@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260917151350.597953846@linuxfoundation.org> References: <20260917151350.597953846@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.2-stable review patch. If anyone has any objections, please let me know. ------------------ From: Fan Wu commit a2471ed17b0e6ff7bfb6b2ea8e6e5b04c309d293 upstream. fan_alarm_irq_handler() queues fan_data->alarm_work, but nothing cancels it. fan_alarm_notify() dereferences fan_data and its hwmon device. On unbind, devres frees the interrupt, which only waits for the handler itself, and then releases the hwmon device and fan_data, so a pending fan_alarm_notify() can run after those frees. Replace INIT_WORK() with devm_work_autocancel(), registered before devm_request_irq(). The devres cleanup then frees the interrupt first, so no new work can be queued, and cancels the work while fan_data and the hwmon device are still alive. This issue was found by an in-house static analysis tool. Fixes: d6fe1360f42e ("hwmon: add generic GPIO fan driver") Cc: stable@vger.kernel.org Assisted-by: Codex:gpt-5.6 Signed-off-by: Fan Wu Link: https://patch.msgid.link/20260819033317.446191-1-fanwu01@zju.edu.cn Signed-off-by: Guenter Roeck Signed-off-by: Greg Kroah-Hartman --- drivers/hwmon/gpio-fan.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) --- a/drivers/hwmon/gpio-fan.c +++ b/drivers/hwmon/gpio-fan.c @@ -12,6 +12,7 @@ #include #include #include +#include #include #include #include @@ -84,6 +85,7 @@ static DEVICE_ATTR_RO(fan1_alarm); static int fan_alarm_init(struct gpio_fan_data *fan_data) { int alarm_irq; + int err; struct device *dev = fan_data->dev; /* @@ -94,7 +96,11 @@ static int fan_alarm_init(struct gpio_fa if (alarm_irq <= 0) return 0; - INIT_WORK(&fan_data->alarm_work, fan_alarm_notify); + err = devm_work_autocancel(dev, &fan_data->alarm_work, + fan_alarm_notify); + if (err) + return err; + irq_set_irq_type(alarm_irq, IRQ_TYPE_EDGE_BOTH); return devm_request_irq(dev, alarm_irq, fan_alarm_irq_handler, IRQF_SHARED, "GPIO fan alarm", fan_data);