From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C2844F3929; Thu, 17 Sep 2026 15:54:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789660441; cv=none; b=qE4ue0YxAu2iV2uGyaYwirnOoZn+KXadsG7KzChXqxFkOQvw+UpzK5LWNrHl9P8Ez9mMck9Spch6BuJy0ftb4Yae5yLlL3aa5Ae62rPyo+rNlhrna+eKiFVMrJUnAxpbHjr7vZydqe6EmccBp0uWGbX4eCfUmerVl450P70dIw8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789660441; c=relaxed/simple; bh=cWAJ4qqVB8sqKSybbjTGQ++4FWzYI7O49outSqr9XgM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HbO1jySBqfA+bLFWSxC6uJ2uCCURWyav17z5uhxroSMTwsUbl7MsIpUblwjr0uItWvbFo9VX+gBoQ4oAUX4Uo/djMzkhoKuBsUZQd0gAemznjMX0GcWItiA1W2ea1rd2/Ul/AvH3nF0NJCbpoXrbR7OWyWzqF/nN0SF5j3ccVAg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=1j3XcSrn; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="1j3XcSrn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B33781F00893; Thu, 17 Sep 2026 15:53:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789660440; bh=z4Kuw8FULzxeONJTHn9G7SfbZoALslvNXzifEKIlLEI=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=1j3XcSrnQzL+PvK2wlDgS6SQPu++/NiAz2Fm71UnFtk4oTGqyR5hkDMZmYXUWOc8L DuWcHoo1ZtauVeVofCOoSf+xxOiAoDkvcmRn3Zdgaqtm2LHIcvOcVC5a7x6VmQd+aQ Abyrsvr7a//EEmMlm7WSMZ5AWk2VBoKqcxdmaX7c= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Vishnu Razdan , Guenter Roeck Subject: [PATCH 7.2 594/733] hwmon: (pmbus) Clear generic status alarms with CLEAR_FAULTS Date: Thu, 17 Sep 2026 16:15:02 +0100 Message-ID: <20260917151407.244126530@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260917151350.597953846@linuxfoundation.org> References: <20260917151350.597953846@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.2-stable review patch. If anyone has any objections, please let me know. ------------------ From: Vishnu Razdan commit 6d760f8b41aed74de4402440e4db663d261478bd upstream. Some hwmon alarms fall back to STATUS_WORD summary bits when no individual limit alarm is available. On PMBus 1.2 and newer devices, pmbus_get_boolean() acknowledges these alarms with the same byte-data write used for detailed status registers. For example, PB_STATUS_INPUT is 0x2000, so it is truncated to zero when passed to _pmbus_write_byte_data(). The resulting write cannot acknowledge the input alarm. PMBus 1.3 Part II, sections 10.2.4 and 10.2.5, excludes ordinary STATUS_BYTE and STATUS_WORD summary bits from individual clearing. Their summary bits clear when the underlying status bits clear, so changing this to a word-data write would not fix the generic input alarm either. Use the existing page CLEAR_FAULTS path for generic STATUS_WORD alarms, including devices whose status accessor uses STATUS_BYTE. Keep individual byte writes for detailed status registers on PMBus 1.2 and newer devices. As with the existing older-device fallback, CLEAR_FAULTS can clear other latched status; an active condition can reassert its status. Fixes: 35f165f08950 ("hwmon: (pmbus) Clear pmbus fault/warning bits after read") Cc: stable@vger.kernel.org Assisted-by: LLM Signed-off-by: Vishnu Razdan Link: https://patch.msgid.link/20260824-vrazdan-pmbus-status-word-b4-v1-1-2606ecd0c029@openai.com Signed-off-by: Guenter Roeck Signed-off-by: Greg Kroah-Hartman --- drivers/hwmon/pmbus/pmbus_core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/hwmon/pmbus/pmbus_core.c +++ b/drivers/hwmon/pmbus/pmbus_core.c @@ -1192,7 +1192,9 @@ static int pmbus_get_boolean(struct i2c_ regval = status & mask; if (regval) { - if (data->revision >= PMBUS_REV_12) { + /* Generic STATUS_WORD alarms are not individually clearable. */ + if (data->revision >= PMBUS_REV_12 && + reg != PMBUS_STATUS_WORD) { ret = _pmbus_write_byte_data(client, page, reg, regval); if (ret) return ret;