From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA1822857EA; Thu, 17 Sep 2026 15:59:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789660764; cv=none; b=bnWjYcThCNH1F42x+srppiE3dZz6QcJ8V5CI8a7Oe6dYqRwFGHa5rM6zsroiAu3YA9e8MvortNbqI+SUUWh7E6tga9ucdAq95MVnHqXZYv0FlUpwlr8gpb4QRyp0ru6rF+emGdKJoU7yXfZII4ADGrEcyZ139i27jo6TusxZZbc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789660764; c=relaxed/simple; bh=i9zoo1KmOMh9qmnKAJcf5hUR62FGTudu8MtJs5yoNns=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EgFLsDhzQ4sGUefagUHKQRolmWyrehutvO7WPPYjFvhTBu64I3uOrXiGCvaTXWiqaSKvIe+/xC8OfkEgTy7nV47dBCbzyB2banlSxn+Ss6u+ASYtep0py5G5dx2dTOjcVKgiVE4wcgoiIDzuvjkhYc9nyV/gDwG9/inrLwmfshY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=lV33ISw3; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="lV33ISw3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D9CE1F000FF; Thu, 17 Sep 2026 15:59:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789660762; bh=CrnUPf9A+NtQxrq08nsmnYvHZppvb+SHXXQ7dSIKyCg=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=lV33ISw3oBajo0lo3ZRwMTRAftNn6yJ9w2xQXxIA/ffrLf9GLSCaOah4qvmqPpqkp NYnNTMKYDVwJelY4sotFDF62irJdE8bVI2ljoJXf1mxP2lWCECSMynfptZWEspxMqh Wv0Eyxs512MHDF93Ay59BznxX10IbB/x4HM12+fI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, "Darrick J. Wong" , Carlos Maiolino , Christoph Hellwig , Carlos Maiolino Subject: [PATCH 7.2 662/733] xfs: fix rtrmap cross-referencing elision logic Date: Thu, 17 Sep 2026 16:16:10 +0100 Message-ID: <20260917151409.173691514@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260917151350.597953846@linuxfoundation.org> References: <20260917151350.597953846@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.2-stable review patch. If anyone has any objections, please let me know. ------------------ From: Darrick J. Wong commit 3bdbf472a608aeb7e8e4dc70ee86738ad5256356 upstream. LOLLM points out that xchk_bmap_xref_rmap_cow skips the cross-reference if the data-section rmapbt cursor is not present. However, this is broken for realtime file data fork scanning, because they will have an rtrmapbt cursor and not an rmapbt cursor. Fix the behavior by removing the cursor checks because xchk_bmap_get_rmap already accounts for that. Cc: stable@vger.kernel.org # v6.14 Fixes: 037a44d8277adf ("xfs: cross-reference the realtime rmapbt") Signed-off-by: Darrick J. Wong Assisted-by: LOLLM # finding obvious bugs Reviewed-by: Carlos Maiolino Reviewed-by: Christoph Hellwig Signed-off-by: Carlos Maiolino Signed-off-by: Greg Kroah-Hartman --- fs/xfs/scrub/bmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/xfs/scrub/bmap.c +++ b/fs/xfs/scrub/bmap.c @@ -274,7 +274,7 @@ xchk_bmap_xref_rmap_cow( unsigned long long rmap_end; uint64_t owner = XFS_RMAP_OWN_COW; - if (!info->sc->sa.rmap_cur || xchk_skip_xref(info->sc->sm)) + if (xchk_skip_xref(info->sc->sm)) return; /* Find the rmap record for this irec. */