From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EE215328DD; Thu, 17 Sep 2026 16:01:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789660875; cv=none; b=DGNfxUiyOy+JYlLjPZh2M0uc1U8uszUNlxHvAGVTbpMcNmaTmLjQbsYNgmvMFCel2vBUXwv7QnkDbZ7kTv+LdwzBZRRXeV1sPeTBp9ERuF1Cp2XM/UHpEPzdpfpSi0G/5kWGGrHXs2JkDQVUBJ6re7zFbBs3E25bAZ/ikE0dJkk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789660875; c=relaxed/simple; bh=5VFw3Tuf/UI5ggircbSpJD88iuYPN93gPjt1JO5dRXU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=D5IOqMkptQLbs2dVxXN1e56+hAyUwgIlvR8175l9dhpleZNZXuQSPreUqwNMq1vM6EOL2yk2ynLW/TZWU7yW0ZstzxLRDbB9P4GkWfVATkGEd96fVC9IIIJtQVxxH6Gsc+r4PHGiidrjdUcX2GR0LpfiuI0gH0naualFveeMvzE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=jK+LHVqr; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="jK+LHVqr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C6A11F000FF; Thu, 17 Sep 2026 16:01:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789660873; bh=n2BvtjZfOA8Uv/fcMotiWrlOw7q6aL8zMOuBgTzkVGg=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=jK+LHVqr9JOFUgq9XOQ+ysGkhODQl6+z8f/pAvcu8JA/044anP7M+y7aibHDMFGAT pT6vim3tLFaLH7G48IwNyEoZF66czuCI39fdtVHyqwfm9EjsaOrzhjWl/Upcz7SZjw 1FjDDr+IJ0Y+H1ztjy921nhp2OnDKXg9BN3Xexd0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Sashiko , Nilesh Javali , "Martin K. Petersen (Oracle)" , Sasha Levin Subject: [PATCH 7.2 705/733] scsi: qla2xxx: Use memset_io() to clear QLAFX00 request ring slot Date: Thu, 17 Sep 2026 16:16:53 +0100 Message-ID: <20260917151410.438972982@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260917151350.597953846@linuxfoundation.org> References: <20260917151350.597953846@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.2-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nilesh Javali [ Upstream commit 626e44f3d8a924a97a3848a9fd45833947e081e9 ] For QLAFX00 the request ring is ioremapped device I/O memory (ha->iobase + req_que_off), not DMA-coherent RAM, which is why the rest of the FX00 path accesses it through memcpy_toio() and the wrt_reg_* helpers. __qla2x00_alloc_iocbs() however zeroed the producer slot with a plain memset(). On architectures such as ARM64 a regular memset() may emit unaligned or block-zeroing instructions (e.g. DC ZVA) that are invalid on Device memory, leading to a synchronous external abort. Use memset_io() to clear the slot for QLAFX00, matching the I/O accessors used elsewhere on this ring. Other adapters keep the plain memset() on their DMA-coherent rings. The zero-fill is retained for FX00 because its IOCB builders (e.g. qlafx00_fxdisc_iocb()) copy only part of the entry and rely on the unused tail being pre-zeroed. Fixes: 8ae6d9c7eb10 ("[SCSI] qla2xxx: Enhancements to support ISPFx00.") Cc: stable@vger.kernel.org Reported-by: Sashiko Signed-off-by: Nilesh Javali Link: https://patch.msgid.link/20260730155838.2119230-12-njavali@marvell.com Signed-off-by: Martin K. Petersen (Oracle) Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/qla2xxx/qla_iocb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/scsi/qla2xxx/qla_iocb.c +++ b/drivers/scsi/qla2xxx/qla_iocb.c @@ -2351,11 +2351,13 @@ __qla2x00_alloc_iocbs(struct qla_qpair * */ req->cnt -= req_cnt; pkt = qla_req_ring_slot(ha, req); - memset(pkt, 0, qla_req_entry_size(ha)); if (IS_QLAFX00(ha)) { + memset_io((void __iomem __force *)pkt, 0, + qla_req_entry_size(ha)); wrt_reg_byte((u8 __force __iomem *)&pkt->entry_count, req_cnt); wrt_reg_dword((__le32 __force __iomem *)&pkt->handle, handle); } else { + memset(pkt, 0, qla_req_entry_size(ha)); pkt->entry_count = req_cnt; pkt->handle = handle; }