From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72B2B3346A8; Thu, 17 Sep 2026 16:00:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789660824; cv=none; b=FgzdqQ0srhUp/1bjPv4oZV7CuUqzVTmFPTiArT/orPLj81qwUh+Ej5ZMWFt7s1Md4rRTZZ03k3KasO92jq7+lVte2rvRwmBWS60wKYpdFd8uTDfEK60eHIiUtThJq6o9vQTwlX7PyK/CTfvDH/odi3tCi2g18r5BKxIO6ZpiXe8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789660824; c=relaxed/simple; bh=SB7VprzbuToOPwJhU8MFNiLQFW78MxenHJB0F3buJzM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EZVzLfqNCiLus95YXR+PLfgbcQwhLvzg+msRvu1mnXKmcyPqaBtmMQt5PRvEgkBkdsCxbd6eq9DjawtBCVLiZ8klbWM3sOO31c/wjYKQDI9j0eqTHzuCifSrrcZ+ZB4vg1HfKfbmXei+wHt2KzWW24GvxcwN+sUEBKfHYs+Xs/s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=nYNHYN9y; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="nYNHYN9y" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6FCFD1F000FF; Thu, 17 Sep 2026 16:00:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789660823; bh=7B1R2aihal3Bnih6rcocVf58v6eMPjRaAaAAkGYFWOo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=nYNHYN9yiFhP91VVkjeVbQ0x4Gol4XtXcjnubl2izvtjd3srlepn05LAq7Z/vZluj PKq/ByaquaLnbK2cPmJh22QpwHN+VFNeiNvjBtQnRq+nXI07mhqraeQXHLAGM6vtOL qzgrLG/Bmn3sgrbCyFD261qPLzK1nv7BCC1rpz+E= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Sashiko , Nilesh Javali , "Martin K. Petersen (Oracle)" , Sasha Levin Subject: [PATCH 7.2 720/733] scsi: qla2xxx: Skip vport under deletion in report ID acquisition Date: Thu, 17 Sep 2026 16:17:08 +0100 Message-ID: <20260917151410.882841032@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260917151350.597953846@linuxfoundation.org> References: <20260917151350.597953846@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.2-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nilesh Javali [ Upstream commit 23582731afa35031c94fadb71a4f3b4afd094649 ] qla24xx_report_id_acquisition() format-1 handling walks ha->vp_list under vport_slock, takes a vref_count on the matching vport and calls qla_update_host_map() to register its port id. A vport teardown via qla24xx_vport_delete() sets VPORT_DELETE, then qla24xx_disable_vp() removes the vport from the host_map btree and zeroes vha->d_id (RESET_AL_PA). The vport is only unlinked from vp_list later, in qla24xx_deallocate_vp_id(), which clears vp_map[idx] (RESET_VP_IDX) but does not touch host_map. In the window in between, report ID acquisition can still find the vport on vp_list and call qla_update_host_map(); with d_id already zeroed it takes the btree_insert32() path and re-inserts the dying vport into host_map. Nothing cleans that entry afterwards, so once scsi_host_put() frees the vha a later host_map lookup dereferences freed memory. Skip a vport that has VPORT_DELETE set before taking the reference, so it is neither re-registered nor scheduled for DPC re-registration. This mirrors the existing guard in qla2x00_alert_all_vps(). Fixes: 41dc529a4602 ("qla2xxx: Improve RSCN handling in driver") Cc: stable@vger.kernel.org Reported-by: Sashiko Signed-off-by: Nilesh Javali Link: https://patch.msgid.link/20260730155838.2119230-22-njavali@marvell.com Signed-off-by: Martin K. Petersen (Oracle) [ Adjusted context to use rptid_entry->vp_idx instead of the missing local vp_idx variable. ] Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/qla2xxx/qla_mbx.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/scsi/qla2xxx/qla_mbx.c +++ b/drivers/scsi/qla2xxx/qla_mbx.c @@ -4204,6 +4204,8 @@ qla24xx_report_id_acquisition(scsi_qla_h spin_lock_irqsave(&ha->vport_slock, flags); list_for_each_entry(vp, &ha->vp_list, list) { if (rptid_entry->vp_idx == vp->vp_idx) { + if (test_bit(VPORT_DELETE, &vp->dpc_flags)) + break; found = 1; atomic_inc(&vp->vref_count); break;