From: sashiko-bot@kernel.org
To: "Wentao Liang" <vulab@iscas.ac.cn>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial: ma35d1: Fix clock reference leak in ma35d1serial_probe()
Date: Thu, 17 Sep 2026 16:03:59 +0000 [thread overview]
Message-ID: <20260917160400.5EAD41F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260917155650.2161274-1-vulab@iscas.ac.cn>
> of_clk_get() returns a clock with a reference that has to be released
> with clk_put(). ma35d1serial_probe() never does that, so the reference
> is leaked on the probe error paths and also when the port is removed.
>
> Release it on the error paths and in ma35d1serial_remove().
>
> Fixes: 930cbf92db01 ("tty: serial: Add Nuvoton ma35d1 serial driver support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260917155650.2161274-1-vulab@iscas.ac.cn?part=1
prev parent reply other threads:[~2026-09-17 16:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 15:56 [PATCH] serial: ma35d1: Fix clock reference leak in ma35d1serial_probe() Wentao Liang
2026-09-17 16:03 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260917160400.5EAD41F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.