From: sashiko-bot@kernel.org
To: "Rafael J. Wysocki" <rafael@kernel.org>,
"Danilo Krummrich" <dakr@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"David Jeffery" <djeffery@redhat.com>,
driver-core@lists.linux.dev
Cc: linux-pci@vger.kernel.org,
"Stuart Hayes" <stuart.w.hayes@gmail.com>,
"Laurence Oberman" <loberman@redhat.com>,
"John Meneghini" <jmeneghi@redhat.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
"Pasha Tatashin" <tatashin@google.com>,
"Ewan Milne" <emilne@redhat.com>,
"John Garry" <john.g.garry@oracle.com>,
"Bart Van Assche" <bvanassche@acm.org>,
"Tarun Sahu" <tarunsahu@google.com>,
linux-kernel@vger.kernel.org, kexec@lists.infradead.org,
Maurizio <mlombard@redhat.com>,
"Jeremy Allison" <jallison@ciq.com>,
linux-scsi@vger.kernel.org, "Bjorn Helgaas" <helgaas@kernel.org>
Subject: Re: [PATCH 3/9] driver core: warn should device_move try to move a need_parent_lock device
Date: Thu, 17 Sep 2026 16:47:54 +0000 [thread overview]
Message-ID: <20260917164755.3566C1F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260917163744.191748-4-djeffery@redhat.com>
> Currently, no device has need_parent_lock set and is moved by
> device_move. need_parent_lock is only set by the usb bus and very
> few device types ever use device_move.
>
> Add a warning to device_move to catch should it ever be used on a
> device with need_parent_lock set. The combination would break
> the immutable relationship needed between parent and child for
> need_parent_lock when locking and unlocking both.
>
> Suggested-by: Tarun Sahu <tarunsahu@google.com>
> Signed-off-by: David Jeffery <djeffery@redhat.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260917163744.191748-1-djeffery@redhat.com?part=3
next prev parent reply other threads:[~2026-09-17 16:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 16:37 [PATCH v22 0/9] shut down devices asynchronously David Jeffery
2026-09-17 16:37 ` [PATCH 1/9] driver core: rely on put_device to free dev->p David Jeffery
2026-09-17 16:45 ` sashiko-bot
2026-09-17 16:37 ` [PATCH 2/9] driver core: prevent device_add() during system shutdown David Jeffery
2026-09-17 16:46 ` sashiko-bot
2026-09-17 16:37 ` [PATCH 3/9] driver core: warn should device_move try to move a need_parent_lock device David Jeffery
2026-09-17 16:47 ` sashiko-bot [this message]
2026-09-17 16:37 ` [PATCH 4/9] driver core: separate function to shutdown one device David Jeffery
2026-09-17 16:40 ` sashiko-bot
2026-09-17 16:37 ` [PATCH 5/9] driver core: do not always lock parent in shutdown David Jeffery
2026-09-17 16:46 ` sashiko-bot
2026-09-17 16:37 ` [PATCH 6/9] driver core: async device shutdown infrastructure David Jeffery
2026-09-17 16:47 ` sashiko-bot
2026-09-17 16:37 ` [PATCH 7/9] PCI: Link a virtual function to its physical function David Jeffery
2026-09-17 16:44 ` sashiko-bot
2026-09-17 16:37 ` [PATCH 8/9] PCI: Enable async shutdown support David Jeffery
2026-09-17 16:48 ` sashiko-bot
2026-09-17 16:37 ` [PATCH 9/9] scsi: " David Jeffery
2026-09-17 16:58 ` sashiko-bot
2026-09-22 16:34 ` [PATCH v22 0/9] shut down devices asynchronously David Jeffery
-- strict thread matches above, loose matches on Subject: below --
2026-09-02 17:07 [PATCH v21 " David Jeffery
2026-09-02 17:07 ` [PATCH 3/9] driver core: warn should device_move try to move a need_parent_lock device David Jeffery
2026-08-21 14:24 [PATCH v20 0/9] shut down devices asynchronously David Jeffery
2026-08-21 14:24 ` [PATCH 3/9] driver core: warn should device_move try to move a need_parent_lock device David Jeffery
2026-08-28 15:50 ` tarunsahu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260917164755.3566C1F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=bvanassche@acm.org \
--cc=dakr@kernel.org \
--cc=djeffery@redhat.com \
--cc=driver-core@lists.linux.dev \
--cc=emilne@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=jallison@ciq.com \
--cc=jmeneghi@redhat.com \
--cc=john.g.garry@oracle.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=loberman@redhat.com \
--cc=martin.petersen@oracle.com \
--cc=mlombard@redhat.com \
--cc=rafael@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=stuart.w.hayes@gmail.com \
--cc=tarunsahu@google.com \
--cc=tatashin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.