Re: [PATCH v4 1/4] dt-bindings: remoteproc: imx_rproc: document memory-region-names to avoid hidden ABI

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: erroneous regex pattern allows invalid region names
--

commit 3fcb4e5cb8e128ab899161b1bbe809e6627ba8ca
Author: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>

dt-bindings: remoteproc: imx_rproc: document memory-region-names to avoid hidden ABI

This commit documents the optional memory-region-names property for the i.MX
remoteproc driver. It explicitly identifies expected memory regions to avoid
relying on memory node names as a hidden ABI.

Link: https://lore.kernel.org/imx/a3602ef8-2b77-4cc3-adef-2c4cba08a5d9@nabladev.com/ [1]
Link: https://lore.kernel.org/imx/alexXTYQHUs76J7v@SMW015318/T/#mb9dc709ff3adc24d9db6d30c973f37b580f6f1f9 [2]

> diff --git a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
> index c18f71b648890..5d98d21035f8c 100644
> --- a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
> @@ -62,6 +62,15 @@ properties:
>      minItems: 1
>      maxItems: 32
>  
> +  memory-region-names:
> +    minItems: 1
> +    maxItems: 32
> +    items:
> +      anyOf:
> +        - const: rsc-table
> +        - pattern: "^vdev[0-9]+(buffer|vring[0-9])+$"

[Severity: Low]
Does this regex pattern correctly validate the memory region names?

By applying the + quantifier to the capture group (buffer|vring[0-9]) rather
than the digit class [0-9], this allows repeated suffixes like
vdev0bufferbuffer or vdev0vring0vring1 to pass schema validation.

It also restricts the vring index to a single digit, so vdev0vring10 would fail.

Should the + be moved to the digit class, such as
"^vdev[0-9]+(buffer|vring[0-9]+)$"?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260917-memory-region-name-v4-0-260755920ebf@nxp.com?part=1