Re: [PATCH 1/1] media: m2m-deinterlace: replace direct ->device_prep*() calls with standard DMA engine API

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] media: m2m-deinterlace: unused variable dmadev
--

commit e18b2f587554971f1ebf19a1e3732c9502cf2d48
Author: Frank Li <Frank.Li@nxp.com>

media: m2m-deinterlace: replace direct ->device_prep*() calls with standard DMA engine API

This commit replaces direct invocations of the DMA engine channel's 
device_prep_*() function pointers with the standard dmaengine wrapper APIs.

> diff --git a/drivers/media/platform/m2m-deinterlace.c b/drivers/media/platform/m2m-deinterlace.c
> index 9dcc4bd6cbdd5..57a91ff2269f2 100644
> --- a/drivers/media/platform/m2m-deinterlace.c
> +++ b/drivers/media/platform/m2m-deinterlace.c
> @@ -330,7 +330,7 @@ static void deinterlace_issue_dma(struct deinterlace_ctx *ctx, int op,
>  	ctx->xt->dst_sgl = true;
>  	flags = DMA_CTRL_ACK | DMA_PREP_INTERRUPT;
>  
> -	tx = dmadev->device_prep_interleaved_dma(chan, ctx->xt, flags);
> +	tx = dmaengine_prep_interleaved_dma(chan, ctx->xt, flags);

[Severity: Low]
Does this change leave dmadev as an unused variable?

Looking at deinterlace_issue_dma(), dmadev is declared and initialized
earlier in the function:

    struct dma_device *dmadev = chan->device;

With this change replacing the direct device_prep_interleaved_dma() 
invocation, it appears dmadev is no longer referenced anywhere else in the 
function, which could result in a build warning.

>  	if (tx == NULL) {
>  		v4l2_warn(&pcdev->v4l2_dev, "DMA interleaved prep error\n");
>  		return;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260917190420.1189246-1-Frank.Li@oss.nxp.com?part=1