From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3108A4E0B7A; Thu, 17 Sep 2026 21:13:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789679587; cv=none; b=X9s9BR0QQsuYcW5ngdscvOt/oGHPUmvqidLgoBsiJOjWPUHLpGRbBC6KwJ5GB+Clhj5FXEoiMo4pRx6HETElKWpzc3bvMTAg1O+4VauPZzVgv0/vsHZXrMRZKWFLPnUiZPhhRzG0fN1maYVupB08A1qjOlOQrZWl52ICDzN8R3I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789679587; c=relaxed/simple; bh=d4tVVwHJienj9tH8PhjAwkusagBy7idEegdJpCu4X74=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Content-Type; b=sU7wQx0gFViUqsUuBvBzoVDBmvMAFcfFIiEzVEPpwBjInLSQxQzCpCOd86uLVrTiTR2C1Y2q8rPPdRwbJs8voeUyoAD5eKw1D4+hq7urN4PeTVQKOkzwvcoWn41NHE0Up3NxfdPES21DSLI9Y6kH+IYBMT3ajZBRw5L/K+JbGhA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mmMzq+Iu; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mmMzq+Iu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C81A31F00893; Thu, 17 Sep 2026 21:13:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789679585; bh=IysZGj9mvs6CQv7lZ09Up1KR0PwOX6bfDHWl8P/2Jvk=; h=From:To:Cc:Subject:Date; b=mmMzq+IugAXiI9SHOJDRvwMsw3OuV9e1h4IGUKwGCbcUvj7Sy/jn9kBmRHLEhTR3F c/x02B+uRdv9SZdqhMZEZ6s350HUDSvw9DV+2E+h7HExtIAhDbWyIC0JhFtuGvqLRv E8fDgeINWKVIJbesQxuc651UZRkRYv0t3o21ESXc7uyzMMivfs7j5Z69GHuRl5OIhV V2Z7HN5apM0PbgV7JlCc1UBFINJvbPyHXqBzMBhJlxDlG63xwCQfEkYkbIGRUPeIxP pzKoJRQC6jgr9isLG+d8K8THcTLZA1rpX6hnOQ5ywDCo4A9C2joouDFN+DgEi8RPTt zKAdUyHv7BuzA== From: Kees Cook To: Vinod Koul Cc: Kees Cook , Kees Cook , Neil Armstrong , Manivannan Sadhasivam , Greg Kroah-Hartman , Stanley Chang , Johan Hovold , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Jinjie Ruan , Rob Herring , Charles Han , linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: [PATCH] phy: realtek: usb: Remove const from phy_cfg allocation type Date: Thu, 17 Sep 2026 14:13:04 -0700 Message-Id: <20260917211303.i.538-kees@kernel.org> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-hardening@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Developer-Signature: v=1; a=openpgp-sha256; l=2685; i=kees@kernel.org; h=from:subject:message-id; bh=dAqZ8oM1ediuouK8ipj2w379RAQqiQUmISyB1GxVvm4=; b=owGbwMvMwCVmps19z/KJym7G02pJDFlrwh/kCr/Nunbz5+cQ9w1bzG5m7VB98FnnNS+f0X2rK 7cnaNcadpSyMIhxMciKKbIE2bnHuXi8bQ93n6sIM4eVCWQIAxenAEzEdgYjw/tTTTlCPK9EC5tE EyvOHrvfZfC86pLpxA+WC25PUZzfEsrI8CQxbOUKT8sHdxPmzNd79cNLUCXg+ish+YDJElfWpBw zYgcA X-Developer-Key: i=kees@kernel.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 Content-Transfer-Encoding: 8bit From: Kees Cook In preparation for making the devm_kmalloc family of allocators type aware, we need to make sure that the returned type from the allocation matches the type of the variable being assigned. (Before, the allocator would always return "void *", which can be implicitly cast to any pointer type.) In both the USB2 and USB3 PHY drivers, the assigned type is "struct phy_cfg *", but the converted allocation type would be "const struct phy_cfg *", as the size was taken from the local "phy_cfg", which points to const as it comes from of_device_get_match_data(). As there is no general way to remove const qualifiers, take the size from the assignment target instead. No change in allocation size results. Build tested ARCH=x86_64 allmodconfig with GCC 16.2.0: drivers/phy/realtek/phy-rtk-usb2.o drivers/phy/realtek/phy-rtk-usb3.o Assisted-by: LLM coccinelle Signed-off-by: Kees Cook --- Cc: Vinod Koul Cc: Neil Armstrong Cc: Manivannan Sadhasivam Cc: Greg Kroah-Hartman Cc: Stanley Chang Cc: Johan Hovold Cc: "Uwe Kleine-König" Cc: Jinjie Ruan Cc: Rob Herring Cc: Charles Han Cc: --- drivers/phy/realtek/phy-rtk-usb2.c | 3 ++- drivers/phy/realtek/phy-rtk-usb3.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/phy/realtek/phy-rtk-usb2.c b/drivers/phy/realtek/phy-rtk-usb2.c index 248550ef98ca..1f08b151d90a 100644 --- a/drivers/phy/realtek/phy-rtk-usb2.c +++ b/drivers/phy/realtek/phy-rtk-usb2.c @@ -1022,7 +1022,8 @@ static int rtk_usb2phy_probe(struct platform_device *pdev) return -ENOMEM; rtk_phy->dev = &pdev->dev; - rtk_phy->phy_cfg = devm_kzalloc(dev, sizeof(*phy_cfg), GFP_KERNEL); + rtk_phy->phy_cfg = devm_kzalloc(dev, sizeof(*rtk_phy->phy_cfg), + GFP_KERNEL); if (!rtk_phy->phy_cfg) return -ENOMEM; diff --git a/drivers/phy/realtek/phy-rtk-usb3.c b/drivers/phy/realtek/phy-rtk-usb3.c index cce453686db2..4231a8aa0ba5 100644 --- a/drivers/phy/realtek/phy-rtk-usb3.c +++ b/drivers/phy/realtek/phy-rtk-usb3.c @@ -576,7 +576,8 @@ static int rtk_usb3phy_probe(struct platform_device *pdev) return -ENOMEM; rtk_phy->dev = &pdev->dev; - rtk_phy->phy_cfg = devm_kzalloc(dev, sizeof(*phy_cfg), GFP_KERNEL); + rtk_phy->phy_cfg = devm_kzalloc(dev, sizeof(*rtk_phy->phy_cfg), + GFP_KERNEL); if (!rtk_phy->phy_cfg) return -ENOMEM; -- 2.34.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 695F6C982D0 for ; Thu, 17 Sep 2026 21:13:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=pkZit/CAqcdijmOdxk6/8CzbNUOmEmjtPnWEEmZUjkU=; b=FTPI3oKT+4VUD9 ttrm+70O6dtP/Kz1eW1CR1DbswGSi40HEzb/QTWlxroLc26sFJTy4al1VuLySfVjnFsR/azZLHT0t S2J9iHyS/u0xGV3QwgPN9YNCuv4fk0RSnCQM4dRMIvFrdKKpHDdXIybehCvwY2RJzWB8w9PFPXzCp npy0LeLkbK60DRsoFWosAuFEdUSDBM30PENTXwDrZF87l1lnie1tmRdBpe55Yj+AeH96N0TqSXZ4M Eq3q0fnsYGbTLfc1cGHGB2Dl9ALPAEY1aCMxsHm2YpZy3ybnPDI7pVNILb6SiThFqwb3IYaApyyw+ dNIY9NytNrgmsiImW1AQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7JPn-0000000CXWQ-4AI5; Thu, 17 Sep 2026 21:13:07 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7JPm-0000000CXWF-3Sph for linux-phy@lists.infradead.org; Thu, 17 Sep 2026 21:13:06 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 1F010601EF; Thu, 17 Sep 2026 21:13:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C81A31F00893; Thu, 17 Sep 2026 21:13:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789679585; bh=IysZGj9mvs6CQv7lZ09Up1KR0PwOX6bfDHWl8P/2Jvk=; h=From:To:Cc:Subject:Date; b=mmMzq+IugAXiI9SHOJDRvwMsw3OuV9e1h4IGUKwGCbcUvj7Sy/jn9kBmRHLEhTR3F c/x02B+uRdv9SZdqhMZEZ6s350HUDSvw9DV+2E+h7HExtIAhDbWyIC0JhFtuGvqLRv E8fDgeINWKVIJbesQxuc651UZRkRYv0t3o21ESXc7uyzMMivfs7j5Z69GHuRl5OIhV V2Z7HN5apM0PbgV7JlCc1UBFINJvbPyHXqBzMBhJlxDlG63xwCQfEkYkbIGRUPeIxP pzKoJRQC6jgr9isLG+d8K8THcTLZA1rpX6hnOQ5ywDCo4A9C2joouDFN+DgEi8RPTt zKAdUyHv7BuzA== From: Kees Cook To: Vinod Koul Cc: Kees Cook , Kees Cook , Neil Armstrong , Manivannan Sadhasivam , Greg Kroah-Hartman , Stanley Chang , Johan Hovold , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Jinjie Ruan , Rob Herring , Charles Han , linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: [PATCH] phy: realtek: usb: Remove const from phy_cfg allocation type Date: Thu, 17 Sep 2026 14:13:04 -0700 Message-Id: <20260917211303.i.538-kees@kernel.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2685; i=kees@kernel.org; h=from:subject:message-id; bh=dAqZ8oM1ediuouK8ipj2w379RAQqiQUmISyB1GxVvm4=; b=owGbwMvMwCVmps19z/KJym7G02pJDFlrwh/kCr/Nunbz5+cQ9w1bzG5m7VB98FnnNS+f0X2rK 7cnaNcadpSyMIhxMciKKbIE2bnHuXi8bQ93n6sIM4eVCWQIAxenAEzEdgYjw/tTTTlCPK9EC5tE EyvOHrvfZfC86pLpxA+WC25PUZzfEsrI8CQxbOUKT8sHdxPmzNd79cNLUCXg+ish+YDJElfWpBw zYgcA X-Developer-Key: i=kees@kernel.org; a=openpgp; fpr=A5C3F68F229DD60F723E6E138972F4DFDC6DC026 X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org RnJvbTogS2VlcyBDb29rIDxrZWVzK3RyZWV3aWRlQGtlcm5lbC5vcmc+CgpJbiBwcmVwYXJhdGlv biBmb3IgbWFraW5nIHRoZSBkZXZtX2ttYWxsb2MgZmFtaWx5IG9mIGFsbG9jYXRvcnMgdHlwZQph d2FyZSwgd2UgbmVlZCB0byBtYWtlIHN1cmUgdGhhdCB0aGUgcmV0dXJuZWQgdHlwZSBmcm9tIHRo ZSBhbGxvY2F0aW9uCm1hdGNoZXMgdGhlIHR5cGUgb2YgdGhlIHZhcmlhYmxlIGJlaW5nIGFzc2ln bmVkLiAoQmVmb3JlLCB0aGUgYWxsb2NhdG9yCndvdWxkIGFsd2F5cyByZXR1cm4gInZvaWQgKiIs IHdoaWNoIGNhbiBiZSBpbXBsaWNpdGx5IGNhc3QgdG8gYW55CnBvaW50ZXIgdHlwZS4pCgpJbiBi b3RoIHRoZSBVU0IyIGFuZCBVU0IzIFBIWSBkcml2ZXJzLCB0aGUgYXNzaWduZWQgdHlwZSBpcwoi c3RydWN0IHBoeV9jZmcgKiIsIGJ1dCB0aGUgY29udmVydGVkIGFsbG9jYXRpb24gdHlwZSB3b3Vs ZCBiZQoiY29uc3Qgc3RydWN0IHBoeV9jZmcgKiIsIGFzIHRoZSBzaXplIHdhcyB0YWtlbiBmcm9t IHRoZSBsb2NhbAoicGh5X2NmZyIsIHdoaWNoIHBvaW50cyB0byBjb25zdCBhcyBpdCBjb21lcyBm cm9tCm9mX2RldmljZV9nZXRfbWF0Y2hfZGF0YSgpLiBBcyB0aGVyZSBpcyBubyBnZW5lcmFsIHdh eSB0byByZW1vdmUgY29uc3QKcXVhbGlmaWVycywgdGFrZSB0aGUgc2l6ZSBmcm9tIHRoZSBhc3Np Z25tZW50IHRhcmdldCBpbnN0ZWFkLiBObyBjaGFuZ2UKaW4gYWxsb2NhdGlvbiBzaXplIHJlc3Vs dHMuCgpCdWlsZCB0ZXN0ZWQgQVJDSD14ODZfNjQgYWxsbW9kY29uZmlnIHdpdGggR0NDIDE2LjIu MDoKZHJpdmVycy9waHkvcmVhbHRlay9waHktcnRrLXVzYjIubwpkcml2ZXJzL3BoeS9yZWFsdGVr L3BoeS1ydGstdXNiMy5vCgpBc3Npc3RlZC1ieTogTExNIGNvY2NpbmVsbGUKU2lnbmVkLW9mZi1i eTogS2VlcyBDb29rIDxrZWVzK3RyZWV3aWRlQGtlcm5lbC5vcmc+Ci0tLQpDYzogVmlub2QgS291 bCA8dmtvdWxAa2VybmVsLm9yZz4KQ2M6IE5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0Bs aW5hcm8ub3JnPgpDYzogTWFuaXZhbm5hbiBTYWRoYXNpdmFtIDxtYW5pQGtlcm5lbC5vcmc+CkNj OiBHcmVnIEtyb2FoLUhhcnRtYW4gPGdyZWdraEBsaW51eGZvdW5kYXRpb24ub3JnPgpDYzogU3Rh bmxleSBDaGFuZyA8c3RhbmxleV9jaGFuZ0ByZWFsdGVrLmNvbT4KQ2M6IEpvaGFuIEhvdm9sZCA8 am9oYW4rbGluYXJvQGtlcm5lbC5vcmc+CkNjOiAiVXdlIEtsZWluZS1Lw7ZuaWciIDx1LmtsZWlu ZS1rb2VuaWdAYmF5bGlicmUuY29tPgpDYzogSmluamllIFJ1YW4gPHJ1YW5qaW5qaWVAaHVhd2Vp LmNvbT4KQ2M6IFJvYiBIZXJyaW5nIDxyb2JoQGtlcm5lbC5vcmc+CkNjOiBDaGFybGVzIEhhbiA8 aGFuY2h1bmNoYW9AaW5zcHVyLmNvbT4KQ2M6IDxsaW51eC1waHlAbGlzdHMuaW5mcmFkZWFkLm9y Zz4KLS0tCiBkcml2ZXJzL3BoeS9yZWFsdGVrL3BoeS1ydGstdXNiMi5jIHwgMyArKy0KIGRyaXZl cnMvcGh5L3JlYWx0ZWsvcGh5LXJ0ay11c2IzLmMgfCAzICsrLQogMiBmaWxlcyBjaGFuZ2VkLCA0 IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9waHkv cmVhbHRlay9waHktcnRrLXVzYjIuYyBiL2RyaXZlcnMvcGh5L3JlYWx0ZWsvcGh5LXJ0ay11c2Iy LmMKaW5kZXggMjQ4NTUwZWY5OGNhLi4xZjA4YjE1MWQ5MGEgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMv cGh5L3JlYWx0ZWsvcGh5LXJ0ay11c2IyLmMKKysrIGIvZHJpdmVycy9waHkvcmVhbHRlay9waHkt cnRrLXVzYjIuYwpAQCAtMTAyMiw3ICsxMDIyLDggQEAgc3RhdGljIGludCBydGtfdXNiMnBoeV9w cm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQogCQlyZXR1cm4gLUVOT01FTTsKIAog CXJ0a19waHktPmRldgkJCT0gJnBkZXYtPmRldjsKLQlydGtfcGh5LT5waHlfY2ZnID0gZGV2bV9r emFsbG9jKGRldiwgc2l6ZW9mKCpwaHlfY2ZnKSwgR0ZQX0tFUk5FTCk7CisJcnRrX3BoeS0+cGh5 X2NmZyA9IGRldm1fa3phbGxvYyhkZXYsIHNpemVvZigqcnRrX3BoeS0+cGh5X2NmZyksCisJCQkJ CUdGUF9LRVJORUwpOwogCWlmICghcnRrX3BoeS0+cGh5X2NmZykKIAkJcmV0dXJuIC1FTk9NRU07 CiAKZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGh5L3JlYWx0ZWsvcGh5LXJ0ay11c2IzLmMgYi9kcml2 ZXJzL3BoeS9yZWFsdGVrL3BoeS1ydGstdXNiMy5jCmluZGV4IGNjZTQ1MzY4NmRiMi4uNDIzMWE4 YWEwYmE1IDEwMDY0NAotLS0gYS9kcml2ZXJzL3BoeS9yZWFsdGVrL3BoeS1ydGstdXNiMy5jCisr KyBiL2RyaXZlcnMvcGh5L3JlYWx0ZWsvcGh5LXJ0ay11c2IzLmMKQEAgLTU3Niw3ICs1NzYsOCBA QCBzdGF0aWMgaW50IHJ0a191c2IzcGh5X3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBk ZXYpCiAJCXJldHVybiAtRU5PTUVNOwogCiAJcnRrX3BoeS0+ZGV2CQkJPSAmcGRldi0+ZGV2Owot CXJ0a19waHktPnBoeV9jZmcgPSBkZXZtX2t6YWxsb2MoZGV2LCBzaXplb2YoKnBoeV9jZmcpLCBH RlBfS0VSTkVMKTsKKwlydGtfcGh5LT5waHlfY2ZnID0gZGV2bV9remFsbG9jKGRldiwgc2l6ZW9m KCpydGtfcGh5LT5waHlfY2ZnKSwKKwkJCQkJR0ZQX0tFUk5FTCk7CiAJaWYgKCFydGtfcGh5LT5w aHlfY2ZnKQogCQlyZXR1cm4gLUVOT01FTTsKIAotLSAKMi4zNC4xCgoKLS0gCmxpbnV4LXBoeSBt YWlsaW5nIGxpc3QKbGludXgtcGh5QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cHM6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcGh5Cg==