From: sashiko-bot@kernel.org
To: "Kees Cook" <kees@kernel.org>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] hwmon: pwm-fan: Add const to channels allocation type
Date: Thu, 17 Sep 2026 21:19:33 +0000 [thread overview]
Message-ID: <20260917211933.95FFE1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260917211417.i.173-kees@kernel.org>
> From: Kees Cook <kees+treewide@kernel.org>
>
> In preparation for making the devm_kmalloc family of allocators type
> aware, we need to make sure that the returned type from the allocation
> matches the type of the variable being assigned. (Before, the allocator
> would always return "void *", which can be implicitly cast to any
> pointer type.)
>
> The assigned type is "const struct hwmon_channel_info **", but the
> converted allocation type would be "struct hwmon_channel_info **", which
> is the same type without the const qualifier. As there is no general way
> to safely add const qualifiers, take the size from the assignment target
> instead. No change in allocation size results.
>
> Build tested ARCH=x86_64 allmodconfig with GCC 16.2.0:
> drivers/hwmon/pwm-fan.o
>
> Assisted-by: LLM coccinelle
> Signed-off-by: Kees Cook <kees+treewide@kernel.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260917211417.i.173-kees@kernel.org?part=1
next prev parent reply other threads:[~2026-09-17 21:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 21:14 [PATCH] hwmon: pwm-fan: Add const to channels allocation type Kees Cook
2026-09-17 21:19 ` sashiko-bot [this message]
2026-09-18 15:05 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260917211933.95FFE1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=kees@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.