From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3165848C3E8 for ; Thu, 17 Sep 2026 21:20:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789680022; cv=none; b=a8PGAVC7B5eRM5s3AxM8rhdYiEn1c5f51bzfJwl8Zz1/dkhSdtd8NviQXBZR8t/SHgmIgyv7GoapZRo7gh4m9JUI85bkuqjGquplAJYK2gGdcCnHoGZRFKNlY6EotbzwAhGTW4hLE0JfaGlWixaoX1aeXZKzmwd0Wtl00QpC9Xg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789680022; c=relaxed/simple; bh=BlG8ybK/7a9b234yW8m9E5A2c8eorZBeODdbCLkzZhI=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=qnLpxk5126Sw/ysQFN1zk38SG1qDRk9N/wtXcr7XbjDpabpyJ1l+a8X64O6ZDwa1MBafp9mlIFi08KSf3FV4CABeKSwUqZq8l/bbeNAhjlURUCe35PAvm2rKFCsldPOuKtH3/MDAxx9QjJXUpfNykGFBroDegdxmmQMefp8D/+o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DR3N4bh4; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DR3N4bh4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4ECE61F00893; Thu, 17 Sep 2026 21:20:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789680019; bh=eEuuZjeGZbBL70xFPAbqfMiUEkk4GDnAKkh1pNrgl7M=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=DR3N4bh4Fw97FLTH2VTk2ezveYhRp8C33yZH/AVfIc34hBBUjbaIq9fg1Xi0M/EUP VWXpK9R1WC9wp/9xtrOr06v1jKANWdhQiulAtjSetqBjV4HS3fi+TD3TalwmYLmwAo E3SmZPRksjg2U3H9I8jBJqgvjc1dPjyi6UMxFUv32MGeo9nUwQaE7Bo5cJrUY9ZmlY 8l+cnQ7UpyIYqmm586l12zktX7328uxRwLhuxT756RVLDiou2KtBhWetHlE36rRfsB cZ9/27+/rALUYObPbj2rn6Ms6DCFy5OoeNqZsFW1WkT/QzQ6mHAzLISNprJ3v4XSqq VEgC7XtGHIWlw== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 4/6] ASoC: meson: aiu: add I2S Capture DAI Reply-To: sashiko-reviews@lists.linux.dev To: "Valerio Setti" Cc: robh@kernel.org, linux-amlogic@lists.infradead.org, neil.armstrong@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org In-Reply-To: <20260917-audin-v2-4-38de4bc1de34@baylibre.com> References: <20260917-audin-v2-0-38de4bc1de34@baylibre.com> <20260917-audin-v2-4-38de4bc1de34@baylibre.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 17 Sep 2026 21:20:18 +0000 Message-Id: <20260917212019.4ECE61F00893@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [High] ASoC: meson: permanent clock divider leak in aiu_encoder_i2s_hw_fr= ee() -- commit 7076c7f044003c89d276b88e15e27dd0533c4d92 Author: Valerio Setti ASoC: meson: aiu: add I2S Capture DAI This commit adds a capture stream to the CPU_I2S_ENCODER, enabling it to handle both playback and capture streams concurrently. It also formats and buffers the captured data using existing components. > diff --git a/sound/soc/meson/aiu.c b/sound/soc/meson/aiu.c > index 535fbf7c16394..14d0e20a4bd66 100644 > --- a/sound/soc/meson/aiu.c > +++ b/sound/soc/meson/aiu.c > @@ -153,6 +153,13 @@ static struct snd_soc_dai_driver aiu_cpu_dai_drv[] = =3D { > .rates =3D SNDRV_PCM_RATE_8000_192000, > .formats =3D AIU_FORMATS, > }, > + .capture =3D { > + .stream_name =3D "I2S Encoder Capture", > + .channels_min =3D 2, > + .channels_max =3D 2, > + .rates =3D SNDRV_PCM_RATE_8000_192000, > + .formats =3D SNDRV_PCM_FMTBIT_S16_LE, > + }, [Severity: High] Does adding this capture stream introduce a permanent clock divider leak wh= en hw_free is explicitly called? Now that both playback and capture streams can be active simultaneously, snd_soc_dai_active(dai) can evaluate to 2. In sound/soc/meson/aiu-encoder-i2s.c:aiu_encoder_i2s_hw_free(): if (snd_soc_dai_active(dai) <=3D 1) aiu_encoder_i2s_divider_enable(component, 0); If a user opens both streams so snd_soc_dai_active(dai) evaluates to 2, and explicitly calls SNDRV_PCM_IOCTL_HW_FREE before closing them, snd_soc_dai_active(dai) remains 2. This skips disabling the clock divider. When the streams are subsequently closed, the ALSA core skips invoking hw_f= ree again because the state was already changed to SNDRV_PCM_STATE_OPEN. This would leave the clock divider permanently enabled, potentially draining bat= tery or blocking system suspend. > .ops =3D &aiu_encoder_i2s_dai_ops, > .symmetric_rate =3D 1, > }, --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260917-audin-v2-0= -38de4bc1de34@baylibre.com?part=3D4 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9FD08C982D0 for ; Thu, 17 Sep 2026 21:20:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lFOGP/CDlk/+mgf7A3gFQdONtyZv8WWKM9qHtGu06jY=; b=Nj5KCMwjpVwYRf QfMmpfOyCQW0/5pvEZJ0pVOryF+ryl8FVnVlPVkbpE2bUNKj87hrsTir/Fpun6cnSuHatslHqCb9K 9CSoItRjNJHoB7KDmjXxOM7Rk/faorj0wj6gEwVy41GLonnZ+6Zm838/f+sgOPDid5Txls6/xuEKm sDAV6kRvgL+Z01X84M00hgHiuvUOGqxpPRzkYFJiLoeRmcdblg+9ZprBWXEUs1KN+JxZ2xd5C0Fa1 +DPrWWeZihfouq9uryKjH60S7Wgb+QhGIeZntqcHDxG0pVLMikJ+lvm3wGhREBAGUAx8qcHC/3hT5 hhCNQkz/MFriOBEEdDVA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7JWo-0000000CYJj-1uTc; Thu, 17 Sep 2026 21:20:22 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7JWm-0000000CYJR-3IQc for linux-amlogic@lists.infradead.org; Thu, 17 Sep 2026 21:20:21 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id EE9EE600AA; Thu, 17 Sep 2026 21:20:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4ECE61F00893; Thu, 17 Sep 2026 21:20:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789680019; bh=eEuuZjeGZbBL70xFPAbqfMiUEkk4GDnAKkh1pNrgl7M=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=DR3N4bh4Fw97FLTH2VTk2ezveYhRp8C33yZH/AVfIc34hBBUjbaIq9fg1Xi0M/EUP VWXpK9R1WC9wp/9xtrOr06v1jKANWdhQiulAtjSetqBjV4HS3fi+TD3TalwmYLmwAo E3SmZPRksjg2U3H9I8jBJqgvjc1dPjyi6UMxFUv32MGeo9nUwQaE7Bo5cJrUY9ZmlY 8l+cnQ7UpyIYqmm586l12zktX7328uxRwLhuxT756RVLDiou2KtBhWetHlE36rRfsB cZ9/27+/rALUYObPbj2rn6Ms6DCFy5OoeNqZsFW1WkT/QzQ6mHAzLISNprJ3v4XSqq VEgC7XtGHIWlw== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 4/6] ASoC: meson: aiu: add I2S Capture DAI To: "Valerio Setti" Cc: robh@kernel.org, linux-amlogic@lists.infradead.org, neil.armstrong@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org In-Reply-To: <20260917-audin-v2-4-38de4bc1de34@baylibre.com> References: <20260917-audin-v2-0-38de4bc1de34@baylibre.com> <20260917-audin-v2-4-38de4bc1de34@baylibre.com> Date: Thu, 17 Sep 2026 21:20:18 +0000 Message-Id: <20260917212019.4ECE61F00893@smtp.kernel.org> X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIEFTb0M6IG1lc29uOiBw ZXJtYW5lbnQgY2xvY2sgZGl2aWRlciBsZWFrIGluIGFpdV9lbmNvZGVyX2kyc19od19mcmVlKCkK LS0KCmNvbW1pdCA3MDc2YzdmMDQ0MDAzYzg5ZDI3NmI4OGUxNWUyN2RkMDUzM2M0ZDkyCkF1dGhv cjogVmFsZXJpbyBTZXR0aSA8dnNldHRpQGJheWxpYnJlLmNvbT4KCkFTb0M6IG1lc29uOiBhaXU6 IGFkZCBJMlMgQ2FwdHVyZSBEQUkKClRoaXMgY29tbWl0IGFkZHMgYSBjYXB0dXJlIHN0cmVhbSB0 byB0aGUgQ1BVX0kyU19FTkNPREVSLCBlbmFibGluZyBpdCB0bwpoYW5kbGUgYm90aCBwbGF5YmFj ayBhbmQgY2FwdHVyZSBzdHJlYW1zIGNvbmN1cnJlbnRseS4gSXQgYWxzbyBmb3JtYXRzCmFuZCBi dWZmZXJzIHRoZSBjYXB0dXJlZCBkYXRhIHVzaW5nIGV4aXN0aW5nIGNvbXBvbmVudHMuCgo+IGRp ZmYgLS1naXQgYS9zb3VuZC9zb2MvbWVzb24vYWl1LmMgYi9zb3VuZC9zb2MvbWVzb24vYWl1LmMK PiBpbmRleCA1MzVmYmY3YzE2Mzk0Li4xNGQwZTIwYTRiZDY2IDEwMDY0NAo+IC0tLSBhL3NvdW5k L3NvYy9tZXNvbi9haXUuYwo+ICsrKyBiL3NvdW5kL3NvYy9tZXNvbi9haXUuYwo+IEBAIC0xNTMs NiArMTUzLDEzIEBAIHN0YXRpYyBzdHJ1Y3Qgc25kX3NvY19kYWlfZHJpdmVyIGFpdV9jcHVfZGFp X2RydltdID0gewo+ICAJCQkucmF0ZXMgPSBTTkRSVl9QQ01fUkFURV84MDAwXzE5MjAwMCwKPiAg CQkJLmZvcm1hdHMgPSBBSVVfRk9STUFUUywKPiAgCQl9LAo+ICsJCS5jYXB0dXJlID0gewo+ICsJ CQkuc3RyZWFtX25hbWUgPSAiSTJTIEVuY29kZXIgQ2FwdHVyZSIsCj4gKwkJCS5jaGFubmVsc19t aW4gPSAyLAo+ICsJCQkuY2hhbm5lbHNfbWF4ID0gMiwKPiArCQkJLnJhdGVzID0gU05EUlZfUENN X1JBVEVfODAwMF8xOTIwMDAsCj4gKwkJCS5mb3JtYXRzID0gU05EUlZfUENNX0ZNVEJJVF9TMTZf TEUsCj4gKwkJfSwKCltTZXZlcml0eTogSGlnaF0KRG9lcyBhZGRpbmcgdGhpcyBjYXB0dXJlIHN0 cmVhbSBpbnRyb2R1Y2UgYSBwZXJtYW5lbnQgY2xvY2sgZGl2aWRlciBsZWFrIHdoZW4KaHdfZnJl ZSBpcyBleHBsaWNpdGx5IGNhbGxlZD8KCk5vdyB0aGF0IGJvdGggcGxheWJhY2sgYW5kIGNhcHR1 cmUgc3RyZWFtcyBjYW4gYmUgYWN0aXZlIHNpbXVsdGFuZW91c2x5LApzbmRfc29jX2RhaV9hY3Rp dmUoZGFpKSBjYW4gZXZhbHVhdGUgdG8gMi4KCkluIHNvdW5kL3NvYy9tZXNvbi9haXUtZW5jb2Rl ci1pMnMuYzphaXVfZW5jb2Rlcl9pMnNfaHdfZnJlZSgpOgoKICAgIGlmIChzbmRfc29jX2RhaV9h Y3RpdmUoZGFpKSA8PSAxKQogICAgICAgIGFpdV9lbmNvZGVyX2kyc19kaXZpZGVyX2VuYWJsZShj b21wb25lbnQsIDApOwoKSWYgYSB1c2VyIG9wZW5zIGJvdGggc3RyZWFtcyBzbyBzbmRfc29jX2Rh aV9hY3RpdmUoZGFpKSBldmFsdWF0ZXMgdG8gMiwgYW5kCmV4cGxpY2l0bHkgY2FsbHMgU05EUlZf UENNX0lPQ1RMX0hXX0ZSRUUgYmVmb3JlIGNsb3NpbmcgdGhlbSwKc25kX3NvY19kYWlfYWN0aXZl KGRhaSkgcmVtYWlucyAyLiBUaGlzIHNraXBzIGRpc2FibGluZyB0aGUgY2xvY2sgZGl2aWRlci4K CldoZW4gdGhlIHN0cmVhbXMgYXJlIHN1YnNlcXVlbnRseSBjbG9zZWQsIHRoZSBBTFNBIGNvcmUg c2tpcHMgaW52b2tpbmcgaHdfZnJlZQphZ2FpbiBiZWNhdXNlIHRoZSBzdGF0ZSB3YXMgYWxyZWFk eSBjaGFuZ2VkIHRvIFNORFJWX1BDTV9TVEFURV9PUEVOLiBUaGlzCndvdWxkIGxlYXZlIHRoZSBj bG9jayBkaXZpZGVyIHBlcm1hbmVudGx5IGVuYWJsZWQsIHBvdGVudGlhbGx5IGRyYWluaW5nIGJh dHRlcnkKb3IgYmxvY2tpbmcgc3lzdGVtIHN1c3BlbmQuCgo+ICAJCS5vcHMgPSAmYWl1X2VuY29k ZXJfaTJzX2RhaV9vcHMsCj4gIAkJLnN5bW1ldHJpY19yYXRlID0gMSwKPiAgCX0sCgotLSAKU2Fz aGlrbyBBSSByZXZpZXcgwrcgaHR0cHM6Ly9zYXNoaWtvLmRldi8jL3BhdGNoc2V0LzIwMjYwOTE3 LWF1ZGluLXYyLTAtMzhkZTRiYzFkZTM0QGJheWxpYnJlLmNvbT9wYXJ0PTQKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFtbG9naWMgbWFpbGlu ZyBsaXN0CmxpbnV4LWFtbG9naWNAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFtbG9naWMK