Re: [PATCH] leds: aat1290: Allocate mm_current_scale with ARRAY_SIZE()

[sashiko-bot@kernel.org]

> From: Kees Cook <kees+treewide@kernel.org>
> 
> In preparation for making the devm_kmalloc family of allocators type
> aware, we need to make sure that the returned type from the allocation
> matches the type of the variable being assigned. (Before, the allocator
> would always return "void *", which can be implicitly cast to any
> pointer type.)
> 
> This allocates one int per entry of max_mm_current_percent, but the size
> was taken from the whole array, which would make the allocation type a
> pointer to the array rather than the "int *" being assigned. Allocate
> ARRAY_SIZE-many entries instead. The resulting allocation size is the
> same: AAT1290_MM_CURRENT_SCALE_SIZE and
> ARRAY_SIZE(max_mm_current_percent) are both 15.
> 
> Build tested ARCH=x86_64 allmodconfig with GCC 16.2.0:
> drivers/leds/flash/leds-aat1290.o
> 
> Assisted-by: LLM coccinelle
> Signed-off-by: Kees Cook <kees+treewide@kernel.org>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260917211357.i.412-kees@kernel.org?part=1