Re: [PATCH v7 08/13] mips: Get rid of custom mips ABIs for syscall tables

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] perf: MIPS syscall tables in tools/perf out of sync
--

commit 19b1ee646fc4511ddca3c13a30ae4d1f9c4582bd
Author: André Almeida <andrealmeid@igalia.com>
mips: Get rid of custom mips ABIs for syscall tables

This commit replaces the MIPS-exclusive ABIs (n32, o32, n64) with "common"
in the syscall tables. It simplifies and unifies the tables without any
functional changes.

> diff --git a/arch/mips/kernel/syscalls/syscall_n64.tbl b/arch/mips/kernel/syscalls/syscall_n64.tbl
> index 83dc93a0712f1..4341b2fd96dad 100644
> --- a/arch/mips/kernel/syscalls/syscall_n64.tbl
> +++ b/arch/mips/kernel/syscalls/syscall_n64.tbl
> @@ -5,385 +5,385 @@
>  # The format is:
>  # <number> <abi> <name> <entry point>
>  #
> -# The <abi> is always "n64" for this file.
> +# The <abi> is always "common" for this file.
>  #
> -0	n64	read				sys_read
> +0	common	read				sys_read

[Severity: Medium]
Does this change break the perf tooling build? 

Building perf via make -C tools/perf runs tools/perf/check-headers.sh, which 
compares the kernel's arch/mips/kernel/syscalls/syscall_n64.tbl against 
tools/perf/arch/mips/entry/syscalls/syscall_n64.tbl. 

Since this patch updates the kernel copy to use common instead of n64 without 
updating the perf copy or its generation scripts, it looks like it will 
trigger a Kernel ABI header differences warning. Furthermore, if a later 
patch deletes the kernel table without updating perf, perf's MIPS syscall 
tracing may be permanently frozen using the old, stale table.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260917-tonyk-syscall_table-v7-0-f4cd8f8e3265@igalia.com?part=8