Re: [PATCH v4 3/7] drm/xe/guc: Make ct_dead_capture available on non-debug config

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] build: xe_guc_ct compile error on !CONFIG_DRM_XE_DEBUG
--

commit 1f4499efdc2f257f0698c2212dc79db666b74590
Author: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>

drm/xe/guc: Make ct_dead_capture available on non-debug config

Define ct_dead_capture for non-debug as well to simplify future
refactor.

> diff --git a/drivers/gpu/drm/xe/xe_guc_ct.c b/drivers/gpu/drm/xe/xe_guc_ct.c
> index b3a6aa37808b4..3353515aa8747 100644
> --- a/drivers/gpu/drm/xe/xe_guc_ct.c
> +++ b/drivers/gpu/drm/xe/xe_guc_ct.c
> @@ -59,6 +59,9 @@ static struct xe_device *ct_to_xe(struct xe_guc_ct *ct)
>  	return gt_to_xe(ct_to_gt(ct));
>  }
>  
> +#define ct_id(reason_code)  CT_DEAD_##reason_code
> +#define CT_DEAD(ct, ctb, reason_code)	ct_dead_capture((ct), (ctb), ct_id(reason_code))
> +
>  #if IS_ENABLED(CONFIG_DRM_XE_DEBUG)
>  enum {
>  	/* Internal states, not error conditions */

[Severity: Low]
Will this break compilation for non-debug builds?

The macro CT_DEAD now unconditionally references CT_DEAD_##reason_code, but
the enumeration defining these reason codes remains strictly guarded by
#if IS_ENABLED(CONFIG_DRM_XE_DEBUG) just below.

Any invocation of CT_DEAD in common code could cause an undeclared identifier
error when CONFIG_DRM_XE_DEBUG is disabled.

[ ... ]

> @@ -2376,4 +2369,10 @@ static void ct_dead_worker_func(struct work_struct *w)
>  
>  	spin_unlock_irq(&ct->dead.lock);
>  }
> +#else
> +static void ct_dead_capture(struct xe_guc_ct *ct, struct guc_ctb *ctb, u32 reason_code)
> +{
> +	if (ctb)
> +		ctb->info.broken = true;
> +}
>  #endif

[Severity: Low]
Does ct_dead_capture() also need a forward declaration for the non-debug
path?

Since this non-debug implementation is defined at the end of the file with
no preceding forward declaration, calling CT_DEAD() earlier in the file may
result in an implicit function declaration error.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260917235923.1521112-9-umesh.nerlige.ramappa@intel.com?part=3