All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Lukas Wunner <lukas@wunner.de>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [l1k:aer_baseline_v1 7/7] drivers/pci/pcie/aer.c:436:29: error: expected ')' before 'pcie_clear_device_status'
Date: Fri, 18 Sep 2026 03:21:16 +0200	[thread overview]
Message-ID: <202609180302.SV9jbPDD-lkp@intel.com> (raw)

tree:   https://github.com/l1k/linux aer_baseline_v1
head:   c03892987cf6c02922172ccd72a517bd7790d3b1
commit: c03892987cf6c02922172ccd72a517bd7790d3b1 [7/7] PCI/AER: Enable baseline capability error reporting
config: arc-randconfig-r2103-20260918 (https://download.01.org/0day-ci/archive/20260918/202609180302.SV9jbPDD-lkp@intel.com/config)
compiler: arc-linux-gcc (GCC) 8.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260918/202609180302.SV9jbPDD-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202609180302.SV9jbPDD-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/pci/pcie/aer.c: In function 'pci_aer_init':
>> drivers/pci/pcie/aer.c:436:29: error: expected ')' before 'pcie_clear_device_status'
     if (pcie_aer_is_native(dev)
        ~                       ^
                                )
      pcie_clear_device_status(dev);
      ~~~~~~~~~~~~~~~~~~~~~~~~   
>> drivers/pci/pcie/aer.c:443:1: error: expected expression before '}' token
    }
    ^
   At top level:
   drivers/pci/pcie/aer.c:264:12: warning: 'pci_enable_pcie_error_reporting' defined but not used [-Wunused-function]
    static int pci_enable_pcie_error_reporting(struct pci_dev *dev)
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +436 drivers/pci/pcie/aer.c

   395	
   396	void pci_aer_init(struct pci_dev *dev)
   397	{
   398		int n;
   399	
   400		if (!pci_is_pcie(dev))
   401			return;
   402	
   403		dev->aer_info = kzalloc_obj(*dev->aer_info);
   404		if (!dev->aer_info)
   405			return;
   406	
   407		ratelimit_state_init(&dev->aer_info->correctable_ratelimit,
   408				     DEFAULT_RATELIMIT_INTERVAL, DEFAULT_RATELIMIT_BURST);
   409		ratelimit_state_init(&dev->aer_info->nonfatal_ratelimit,
   410				     DEFAULT_RATELIMIT_INTERVAL, DEFAULT_RATELIMIT_BURST);
   411	
   412		dev->aer_cap = pci_find_ext_capability(dev, PCI_EXT_CAP_ID_ERR);
   413		if (!dev->aer_cap)
   414			goto enable;
   415	
   416		/*
   417		 * We save/restore PCI_ERR_UNCOR_MASK, PCI_ERR_UNCOR_SEVER,
   418		 * PCI_ERR_COR_MASK, and PCI_ERR_CAP.  Root and Root Complex Event
   419		 * Collectors also implement PCI_ERR_ROOT_COMMAND (PCIe r6.0, sec
   420		 * 7.8.4.9).
   421		 */
   422		n = pcie_cap_has_rtctl(dev) ? 5 : 4;
   423		pci_add_ext_cap_save_buffer(dev, PCI_EXT_CAP_ID_ERR, sizeof(u32) * n);
   424	
   425		/*
   426		 * Advisory Non-Fatal Errors are masked by default (PCIe r7.0, sec
   427		 * 7.8.4.6).
   428		 */
   429		if (pcie_aer_is_native(dev) && dev->devcap & PCI_EXP_DEVCAP_RBER)
   430			pci_clear_and_set_config_dword(dev,
   431						       dev->aer_cap + PCI_ERR_COR_MASK,
   432						       PCI_ERR_COR_ADV_NFAT, 0);
   433	
   434		pci_aer_clear_status(dev);
   435	enable:
 > 436		if (pcie_aer_is_native(dev)
   437			pcie_clear_device_status(dev);
   438	
   439		if (pci_aer_available())
   440			pci_enable_pcie_error_reporting(dev);
   441	
   442		pcie_set_ecrc_checking(dev);
 > 443	}
   444	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2026-09-18  1:21 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202609180302.SV9jbPDD-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=lukas@wunner.de \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.