Re: [PATCH 05/11] PCI: rcar-gen4: Split reusable hardware initialization

[sashiko-bot@kernel.org]

> Prepare for Root Port recovery, which is going to reset and reinitialize
> the controller with the same sequence probe uses, minus the steps that
> must only run once.
> 
> Move clock enabling out of rcar_gen4_pcie_common_init() into
> rcar_gen4_pcie_clk_enable(), so the power reset and mode setup in
> common_init() can be re-run with the clocks already on. Gating the
> clocks as well would add nothing: the "pwr" reset is the controller's
> cold reset (power_up_rst_n) and resets all PCIEC registers by itself.
> 
> Split rcar_gen4_pcie_host_init() into rcar_gen4_pcie_host_hw_init(),
> the part Root Port reset will reuse, and a probe-only wrapper.
> 
> The power reset is now asserted unconditionally, since recovery calls
> common_init() with the controller running. At probe the block is
> usually held in reset already, so this only adds a 1 ms wait there.
> 
> Propagate reset-controller errors while at it.
> 
> Signed-off-by: Koichiro Den <den@valinux.co.jp>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260918032038.2216471-1-den@valinux.co.jp?part=5