From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE015C982D6 for ; Fri, 18 Sep 2026 04:28:10 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x7QAO-0005aA-JI; Fri, 18 Sep 2026 00:25:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x7QAM-0005Zn-QR for qemu-devel@nongnu.org; Fri, 18 Sep 2026 00:25:38 -0400 Received: from mail-oi2-x1b.google.com ([2607:f8b0:4864:32::1b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1x7QAL-0004Np-2e for qemu-devel@nongnu.org; Fri, 18 Sep 2026 00:25:38 -0400 Received: by mail-oi2-x1b.google.com with SMTP id 46e09a7af769-7f4f0d37dccso144660a34.3 for ; Thu, 17 Sep 2026 21:25:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20251104.gappssmtp.com; s=20251104; t=1789705536; x=1790310336; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=FmM8f1a/31ZZH4KQhAtlbXbGZ6RWTojPX0uu/A3l5ag=; b=nqyQJ6yVjLfaPQP9I/ENKi7zTvIzJgZs703LhnVzFn/Ravb81r4OK+KDzihzWLwzQM 7TqY41OPeoVjEBxid2h4EzvQOGN7k4uwhcBOOLNZ/zHSM2bRsoK/YVFlpM7/R41gFKzG 9v7oWZozJST4RxKmZ37T1W3oknn3KUAMHgsqIaAycTDKvTJTQvVyH6k7SAa7VGnSC0SJ Od6S4sG3Q01OLsXXHjqojwMqwyvqEnIz1ixjE80o48lsjLGU/UboW96+BQUgReuvXK66 J7NwT1K6DIHuCRF7DA8SBokrnbXu9FQyfdW77ciWlKwtftgHCyvW3WPTExNAcb0pr9Wx K6nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789705536; x=1790310336; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=FmM8f1a/31ZZH4KQhAtlbXbGZ6RWTojPX0uu/A3l5ag=; b=qlZ4pF28MpQBm4OI84saeC8Je++rRifkAfL5Txj8r51VZkGjWAZ4QMhjUMLuvyiJbE 7Wu8mzotU9DQNIfduTfCYUUvBsK38MtRwetRvpUqkWz559a4OLu1AaYKSD4aI/o0HLMS VTHX+3/sGI5tlJNIG8CCh1K+fdmOMQsqsyL+qViWPmrHamZMnTo6XCnQCCPtXXZvi7VZ AnDH/yWQDOHLoWBzfywr8hloO7jrNuX0IisgPgWL7SZR96ivWF6rPOQwUJVyohmLDaYU CgBcfdVcLzS0kXwIjUjbAol72B739l2D7ocdl2vPHJ2oMaaE9Oc6CNCPGMG8XgQ3oyZ3 0gKQ== X-Gm-Message-State: AFuF++kQGJ8ZxpC2NZt43Dd0WEv135zdutokeJSllRjRlqDFndY+ZjJR 28QcK7wfI5xhbAq/JQyftBMv32DmaD8npNTlT8aKaZ9C8qxm+e1BVS6KAKBnRwqR1/eVgokLOs2 oG7FuCu4= X-Gm-Gg: AYBFou3pP6TLnVLPehLoOg0h42mpKksT79/V8LhuF39ewCyjbPod2N/QdHFWnacfGm3 INBrEZOPspAN7C8kBJo1S+CNWe5yXr3Bzx75nQ+9SNHBe3Pfhe5E5/aELAehyCbSeOUHwOB1cJ0 PqjVzl8D5ulL25WEOrOCXs8aFZ2e6+h0Q1GYGwlDl6ZMnbKI0lFQwiE+WB99p50KtnhIGaPfl/d DpHNxsZlgczcgU3Wcb3xSWPFY9LYzmX6U9OlmxDKq529cXZ9KapChyYdKazjFNTl+k/Md++i3st goE+BrFYXu0AHH+8UMj2bQWAaNRgh/S9ibYWDXZ3ny66ePvWg4gYJl6N9McDrhSRpEXIYlq2aZO +xQS2UOiySq1abIFJ3cGe7XFU3384RqvW9Jnaffma0ChYBAByEL3uZpQnES7sWEx8im1eSCm6wc jcu5Vg8JJjIludBWIp1rsDttuPSaJ6ctfvn7aNZsitFN7gdHbB4MAEYh0nIw== X-Received: by 2002:a05:6830:6a8b:b0:7fa:ac4f:788 with SMTP id 46e09a7af769-80de2bccf13mr1408287a34.20.1789705536016; Thu, 17 Sep 2026 21:25:36 -0700 (PDT) Received: from rebo.bsdimp.com ([50.253.99.174]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-80e51d627b5sm489718a34.20.2026.09.17.21.25.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Sep 2026 21:25:35 -0700 (PDT) From: Warner Losh To: qemu-devel@nongnu.org Cc: Kyle Evans , Warner Losh , Stacey Son , =?UTF-8?q?Mika=C3=ABl=20Urankar?= , Kyle Evans , Richard Henderson Subject: [PULL 24/41] bsd-user: Add select, pselect, and ppoll to os-time.h Date: Thu, 17 Sep 2026 22:24:05 -0600 Message-ID: <20260918042422.38713-25-imp@bsdimp.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260918042422.38713-1-imp@bsdimp.com> References: <20260918042422.38713-1-imp@bsdimp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: none client-ip=2607:f8b0:4864:32::1b; envelope-from=imp@bsdimp.com; helo=mail-oi2-x1b.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Add I/O multiplexing system call shims: select, pselect, and ppoll with proper fd_set, timespec/timeval, and signal mask conversion. Signed-off-by: Stacey Son Signed-off-by: Mikaël Urankar Signed-off-by: Kyle Evans Assisted-by: Claude Opus 4.6 (1M context) Acked-by: Richard Henderson Signed-off-by: Warner Losh --- bsd-user/freebsd/os-time.h | 202 +++++++++++++++++++++++++++++++++++++ 1 file changed, 202 insertions(+) diff --git a/bsd-user/freebsd/os-time.h b/bsd-user/freebsd/os-time.h index 06104a5b7d..5f537fac40 100644 --- a/bsd-user/freebsd/os-time.h +++ b/bsd-user/freebsd/os-time.h @@ -433,5 +433,207 @@ static inline abi_long do_freebsd_ktimer_gettime(abi_long arg1, abi_long arg2) return ret; } +/* select(2) */ +static inline abi_long do_freebsd_select(CPUArchState *env, int n, + abi_ulong rfd_addr, abi_ulong wfd_addr, abi_ulong efd_addr, + abi_ulong target_tv_addr) +{ + fd_set rfds, wfds, efds; + fd_set *rfds_ptr, *wfds_ptr, *efds_ptr; + struct timeval tv, *tvp; + abi_long ret, error; + + ret = copy_from_user_fdset_ptr(&rfds, &rfds_ptr, rfd_addr, n); + if (ret != 0) { + return ret; + } + ret = copy_from_user_fdset_ptr(&wfds, &wfds_ptr, wfd_addr, n); + if (ret != 0) { + return ret; + } + ret = copy_from_user_fdset_ptr(&efds, &efds_ptr, efd_addr, n); + if (ret != 0) { + return ret; + } + + if (target_tv_addr != 0) { + if (t2h_freebsd_timeval(&tv, target_tv_addr)) { + return -TARGET_EFAULT; + } + tvp = &tv; + } else { + tvp = NULL; + } + + ret = get_errno(safe_select(n, rfds_ptr, wfds_ptr, efds_ptr, tvp)); + + if (!is_error(ret)) { + if (rfd_addr != 0) { + error = copy_to_user_fdset(rfd_addr, &rfds, n); + if (error != 0) { + return error; + } + } + if (wfd_addr != 0) { + error = copy_to_user_fdset(wfd_addr, &wfds, n); + if (error != 0) { + return error; + } + } + if (efd_addr != 0) { + error = copy_to_user_fdset(efd_addr, &efds, n); + if (error != 0) { + return error; + } + } + if (target_tv_addr != 0) { + error = h2t_freebsd_timeval(&tv, target_tv_addr); + if (is_error(error)) { + return error; + } + } + } + return ret; +} + +/* pselect(2) */ +static inline abi_long do_freebsd_pselect(CPUArchState *env, int n, + abi_ulong rfd_addr, abi_ulong wfd_addr, abi_ulong efd_addr, + abi_ulong ts_addr, abi_ulong set_addr) +{ + CPUState *cpu = env_cpu(env); + TaskState *tstate = cpu->opaque; + fd_set rfds, wfds, efds; + fd_set *rfds_ptr, *wfds_ptr, *efds_ptr; + sigset_t *set_ptr; + struct timespec ts, *ts_ptr; + void *p; + abi_long ret, error; + + ret = copy_from_user_fdset_ptr(&rfds, &rfds_ptr, rfd_addr, n); + if (is_error(ret)) { + return ret; + } + ret = copy_from_user_fdset_ptr(&wfds, &wfds_ptr, wfd_addr, n); + if (is_error(ret)) { + return ret; + } + ret = copy_from_user_fdset_ptr(&efds, &efds_ptr, efd_addr, n); + if (is_error(ret)) { + return ret; + } + + /* Unlike select(), pselect() uses struct timespec instead of timeval */ + if (ts_addr) { + if (t2h_freebsd_timespec(&ts, ts_addr)) { + return -TARGET_EFAULT; + } + ts_ptr = &ts; + } else { + ts_ptr = NULL; + } + + if (set_addr != 0) { + p = lock_user(VERIFY_READ, set_addr, sizeof(target_sigset_t), 1); + if (p == NULL) { + return -TARGET_EFAULT; + } + target_to_host_sigset(&tstate->sigsuspend_mask, p); + unlock_user(p, set_addr, 0); + set_ptr = &tstate->sigsuspend_mask; + } else { + set_ptr = NULL; + } + + ret = get_errno(safe_pselect(n, rfds_ptr, wfds_ptr, efds_ptr, ts_ptr, + set_ptr)); + if (ret != -TARGET_ERESTART) { + tstate->in_sigsuspend = true; + } + if (!is_error(ret)) { + if (rfd_addr != 0) { + error = copy_to_user_fdset(rfd_addr, &rfds, n); + if (is_error(error)) { + return error; + } + } + if (wfd_addr != 0) { + error = copy_to_user_fdset(wfd_addr, &wfds, n); + if (is_error(error)) { + return error; + } + } + if (efd_addr != 0) { + error = copy_to_user_fdset(efd_addr, &efds, n); + if (is_error(error)) { + return error; + } + } + } + return ret; +} + +/* ppoll(2) */ +static inline abi_long do_freebsd_ppoll(CPUArchState *env, abi_long arg1, + abi_long arg2, abi_ulong arg3, abi_ulong arg4) +{ + CPUState *cpu = env_cpu(env); + TaskState *tstate = cpu->opaque; + abi_long ret; + nfds_t i, nfds = arg2; + struct pollfd *pfd; + struct target_pollfd *target_pfd; + struct timespec ts, *ts_ptr; + sigset_t *set_ptr; + void *p; + + target_pfd = lock_user(VERIFY_WRITE, arg1, + sizeof(struct target_pollfd) * nfds, 1); + if (!target_pfd) { + return -TARGET_EFAULT; + } + pfd = alloca(sizeof(struct pollfd) * nfds); + for (i = 0; i < nfds; i++) { + pfd[i].fd = tswap32(target_pfd[i].fd); + pfd[i].events = tswap16(target_pfd[i].events); + } + + /* Unlike poll(), ppoll() uses struct timespec. */ + if (arg3) { + if (t2h_freebsd_timespec(&ts, arg3)) { + return -TARGET_EFAULT; + } + ts_ptr = &ts; + } else { + ts_ptr = NULL; + } + + if (arg4 != 0) { + p = lock_user(VERIFY_READ, arg4, sizeof(target_sigset_t), 1); + if (p == NULL) { + return -TARGET_EFAULT; + } + target_to_host_sigset(&tstate->sigsuspend_mask, p); + unlock_user(p, arg4, 0); + set_ptr = &tstate->sigsuspend_mask; + } else { + set_ptr = NULL; + } + + ret = get_errno(ppoll(pfd, nfds, ts_ptr, set_ptr)); + if (ret != -TARGET_ERESTART) { + tstate->in_sigsuspend = true; + } + if (!is_error(ret)) { + for (i = 0; i < nfds; i++) { + target_pfd[i].revents = tswap16(pfd[i].revents); + } + } + unlock_user(target_pfd, arg1, sizeof(struct target_pollfd) * nfds); + + return ret; +} + +/* kqueue(2) */ #endif /* FREEBSD_OS_TIME_H */ -- 2.55.0