Re: [PATCH v1 5/5] perf thread: Free the comm read from procfs

[sashiko-bot@kernel.org]

> procfs__read_str() allocates the buffer it hands back and
> thread__set_comm() only stores an interned copy of the string, so the
> caller owns the buffer. thread__set_comm_from_proc() freed it when the
> read came back empty but not once it had been used, leaking it on
> every successful call.
> 
> Free it on both paths. The empty read still returns -1, err being
> untouched in that case.
> 
> Found with leak sanitizer while running 'perf trace':
> 
>   Direct leak of 7 byte(s) in 1 object(s) allocated from:
>       #1 io__getdelim fs/../io.h:179
>       #2 filename__read_str fs/fs.c:365
>       #3 procfs__read_str fs/fs.c:402
>       #4 thread__set_comm_from_proc util/thread.c:297
>       #5 syscall_arg__scnprintf_pid trace/beauty/pid.c:15
> 
> Assisted-by: Antigravity:gemini-3.1-pro
> Signed-off-by: Ian Rogers <irogers@google.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260918063249.2172589-1-irogers@google.com?part=5