From: Triet Hoang <triet.hoang.dev@gmail.com>
To: tomi.valkeinen@ideasonboard.com
Cc: kernel-list@raspberrypi.com, mchehab@kernel.org,
naush@raspberrypi.com, sakari.ailus@linux.intel.com,
linux-media@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Triet Hoang <triet.hoang.dev@gmail.com>
Subject: [PATCH] media: raspberrypi: Fix error handling for media_entity_remote_source_pad_unique()
Date: Fri, 18 Sep 2026 13:48:32 +0700 [thread overview]
Message-ID: <20260918064832.891339-1-triet.hoang.dev@gmail.com> (raw)
The media_entity_remote_source_pad_unique() function returns an error
pointer on failure, not NULL. Fix the check to use IS_ERR() and return
PTR_ERR() to correctly handle allocation failures.
Fixes: 6edb685abb2a ("media: raspberrypi: Add support for RP1-CFE")
Signed-off-by: Triet Hoang <triet.hoang.dev@gmail.com>
---
drivers/media/platform/raspberrypi/rp1-cfe/cfe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c b/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
index 8375ed3e97b9..91e9fa0341e0 100644
--- a/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
+++ b/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
@@ -1779,7 +1779,7 @@ static int cfe_video_link_validate(struct media_link *link)
link->source->entity->name, link->source->index,
link->sink->entity->name, link->sink->index);
- if (!media_entity_remote_source_pad_unique(link->sink->entity)) {
+ if (IS_ERR(media_entity_remote_source_pad_unique(link->sink->entity))) {
cfe_err(cfe, "video node %s pad not connected\n", vd->name);
return -ENOTCONN;
}
--
2.53.0
reply other threads:[~2026-09-18 6:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260918064832.891339-1-triet.hoang.dev@gmail.com \
--to=triet.hoang.dev@gmail.com \
--cc=kernel-list@raspberrypi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=naush@raspberrypi.com \
--cc=sakari.ailus@linux.intel.com \
--cc=tomi.valkeinen@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.