From: Maarten Lankhorst <dev@lankhorst.se>
To: intel-xe@lists.freedesktop.org
Cc: Maarten Lankhorst <dev@lankhorst.se>
Subject: [PATCH 2/2] drm/xe: Set job credits based on LRC size
Date: Fri, 18 Sep 2026 10:16:09 +0200 [thread overview]
Message-ID: <20260918081609.518988-3-dev@lankhorst.se> (raw)
In-Reply-To: <20260918081609.518988-1-dev@lankhorst.se>
This allows to fill the entire LRC and increase
to a higher limit of outstanding jobs without throttling.
Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
---
drivers/gpu/drm/xe/xe_execlist.c | 2 +-
drivers/gpu/drm/xe/xe_guc_submit.c | 2 +-
drivers/gpu/drm/xe/xe_sched_job.c | 8 +++++---
3 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_execlist.c b/drivers/gpu/drm/xe/xe_execlist.c
index a36db39dcda8a..94d4d982f79b3 100644
--- a/drivers/gpu/drm/xe/xe_execlist.c
+++ b/drivers/gpu/drm/xe/xe_execlist.c
@@ -329,7 +329,7 @@ static int execlist_exec_queue_init(struct xe_exec_queue *q)
const struct drm_sched_init_args args = {
.ops = &drm_sched_ops,
.num_rqs = 1,
- .credit_limit = xe_lrc_ring_size() / MAX_JOB_SIZE_BYTES,
+ .credit_limit = xe_lrc_ring_size(),
.hang_limit = XE_SCHED_HANG_LIMIT,
.timeout = XE_SCHED_JOB_TIMEOUT,
.name = q->hwe->name,
diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
index 6144a1767f10d..7d117f53f990e 100644
--- a/drivers/gpu/drm/xe/xe_guc_submit.c
+++ b/drivers/gpu/drm/xe/xe_guc_submit.c
@@ -2089,7 +2089,7 @@ static int guc_exec_queue_init(struct xe_exec_queue *q)
}
err = xe_sched_init(&ge->sched, &drm_sched_ops, &xe_sched_ops,
- submit_wq, xe_lrc_ring_size() / MAX_JOB_SIZE_BYTES, 64,
+ submit_wq, xe_lrc_ring_size(), 64,
timeout, guc_to_gt(guc)->ordered_wq, NULL,
ge->name, gt_to_xe(q->gt)->drm.dev);
if (err)
diff --git a/drivers/gpu/drm/xe/xe_sched_job.c b/drivers/gpu/drm/xe/xe_sched_job.c
index 57ed6734d31d5..be99d9cd16ad3 100644
--- a/drivers/gpu/drm/xe/xe_sched_job.c
+++ b/drivers/gpu/drm/xe/xe_sched_job.c
@@ -114,8 +114,8 @@ struct xe_sched_job *xe_sched_job_create(struct xe_exec_queue *q,
kref_init(&job->refcount);
xe_exec_queue_get(job->q);
- err = drm_sched_job_init(&job->drm, q->entity, 1, NULL,
- q->xef ? q->xef->drm->client_id : 0);
+ err = drm_sched_job_init(&job->drm, q->entity, MAX_JOB_SIZE_BYTES,
+ NULL, q->xef ? q->xef->drm->client_id : 0);
if (err)
goto err_free;
@@ -295,8 +295,10 @@ void xe_sched_job_push(struct xe_sched_job *job)
xe_sched_job_get(job);
trace_xe_sched_job_exec(job);
- if (!job->restore_replay)
+ if (!job->restore_replay) {
job->q->ring_ops->prepare_job(job);
+ job->drm.credits = job->ptrs[0].job_size;
+ }
drm_sched_entity_push_job(&job->drm);
xe_sched_job_put(job);
--
2.55.0
next prev parent reply other threads:[~2026-09-18 8:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 8:16 [PATCH 0/2] drm/xe: Increase job depth Maarten Lankhorst
2026-09-18 8:16 ` [PATCH 1/2] drm/xe: Convert job preparation in 2 stages Maarten Lankhorst
2026-09-18 8:16 ` Maarten Lankhorst [this message]
2026-09-18 8:32 ` [PATCH 2/2] drm/xe: Set job credits based on LRC size sashiko-bot
2026-09-18 8:22 ` ✗ CI.checkpatch: warning for drm/xe: Increase job depth Patchwork
2026-09-18 8:24 ` ✓ CI.KUnit: success " Patchwork
2026-09-18 9:15 ` ✓ Xe.CI.BAT: " Patchwork
2026-09-18 17:12 ` ✗ Xe.CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260918081609.518988-3-dev@lankhorst.se \
--to=dev@lankhorst.se \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.