From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 393A1C982DC for ; Fri, 18 Sep 2026 09:11:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MxvnyWr05WcVKTSaKimPAhnV/v3SzZ+GK7Q5YfqFFQ4=; b=iXuTyTh/RsJihG PZskUtY+52KVgMrCU0KzKGUFZB8EU9Pwh48nKHTBflKYMEuIOKzX6VSVbmez1iv92UGzh6qNW0ne/ 7ipXayldU25sAlM5XxTkmrZ1RzXKgTkVWKMhj2VQxLAra+Cx66Illl8THlckJkJie614HlL/tVcYf 3zThXrz7y+m6/pO7NcVS5EwmdT2Xj3pkSAtwwOdUCwdkIhg9BBaY+1No9jzBu3i/U3oQ46WW09Ssl qk9+Z726Q/1DSgjVC7Mkn5s4xc/GyQDNWRinSXF6/B6YkQMS2zWFa78IAhkq9ZJOyXogLyVhAADjY /imzgE6XekI6eZu3SU5Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7UdE-0000000DtrK-1FLv; Fri, 18 Sep 2026 09:11:44 +0000 Received: from mail-wm2-f13.google.com ([74.125.225.141]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7UdA-0000000DtoQ-2puK for linux-rockchip@lists.infradead.org; Fri, 18 Sep 2026 09:11:42 +0000 Received: by mail-wm2-f13.google.com with SMTP id 5b1f17b1804b1-49e71974de4so159485e9.1 for ; Fri, 18 Sep 2026 02:11:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789722697; x=1790327497; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=yZ/vqBSgFHqCJoAqatA3IE2jvlq836FlV9wvuCTBolI=; b=eteVM4DkX2YdJStF8RN9lDBRWoKHT22ScfaP9vhGkY0UguBsFmgxKL0LFMpwUp6Bj1 ps3xCDy0HxFpHis08xgsyjutMryP2SuamgnHdIbVnPF+86tq8lYDK12wagzhY9GLAcdh u3PuRN6MCEtGWIVic1R4ilpQMvjqlFz9Iyk+Kw9W9zb6tAXnospEX6dHh2kj3u6qqxba OFIBJKmZB33aU0jHis0i7/bzdfcmAjJY6gR5CyDXTN42Y/hrpzBZyU3YgoJ4Twtphzms vmY+gkraw63QHwzpROZmCIyzK1lxnbqBtDL1KJQoxJRfKkgQ7n1+XgboBCy8n7mkviPp cjHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789722697; x=1790327497; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=yZ/vqBSgFHqCJoAqatA3IE2jvlq836FlV9wvuCTBolI=; b=WNraOVk8ynQDp8/x04KKky0npevAqiE+IjKXP6z436bXLUMaB+5/dQKLLoNrkZhWys iOHYQHcge+JD0F2htu8GJxcTXRSaXF7V/5aO3vOpVrsqlwJXcn0bHXA4xdGTkzraaPIP CpvZ77XIkQ1olcwAbYN8CwLHa3hcjZ5k835EJYD+1f1yAeK6mN1PEIfGdPRYP9oMLxYY iRvo1JIU0boatKEgl41Gb9Bq8zo2dHIc2uAHecd80oKXY0ejjZ7mtEmci1AhQJtvXAuK cdk0EGGZrrJ6RZB8of0b6cEwnUYBWkcyqTp1RSTxJG/9Ct3vZeTk3wCBEZm40CMHfiZX KYBA== X-Forwarded-Encrypted: i=1; AKwUvBxc9fyl3OmEfFsmZlRYQ2F0rZWeE5ZgmBAjbBdSFGbcQMY5bndIWtH+S2JXiTsPIgakot0Ov+hmrc0WwyNWiQ==@lists.infradead.org X-Gm-Message-State: AFuF++nLXRZdv2YyZKWLjpAtaYgISc+fUOzCnBJI6g1gA/MoOGR1DIWD ATyX+m5tuYO4J7rGc3F4Y48ekr5+Dp23zQX6j13CMd8Tfk4kf0o2fKbrrZUW/w== X-Gm-Gg: AYBFou1+PZDe/BD6me0lQnlr0DNfXCb4n7O7G2sam7+FnzhZcHJJvIpC1FUrp7NPBXn AcHGNakWsZNdbS0Z4K1PVprNxthqmtL7N3Q+V/0GRwlwA7MLT0gk7cHurwCbchA9L4ZUagSR+7/ RXccRqPLUrXJ7X2JuYgUjFdFJ30p/yIaDgvNhvVCqdDx/MdQPhSd9fRF6UqE+/K8GF5FPxvOp5D FOd215d6rzE2ijfrbd2tHRHXquGyGE2E+STf5VfOSQbBhXppU3ql3IHUJ56ppOC/n7n62iP4O/G /l47kI/t3NvjwJMS0qY2SlLv6RDiLb6pp6ghINtvL660hRuWyvJKzOSCr90iG3WY1OPu4iNc2or /Asfu04/NarUt1p+IbpVXf53AhObIVWHSg5crwnA8Bb1aZxhAaNuCRd0O/rpuXpoqPgebmIMfWw 4vFNCooWKhnEXbdrZXBlNlCPsZyLPmmagO+jvokIoRcsx2e8FCGMjXQbZEOzhBkC/iBnt9Ac/iG nnEJqc2/bXiPP/8Df1SovcF1byIpGuPuiypALotx0WXsojApMTq02mI84yApXnWOA+2bocMGOOO cGhV X-Received: by 2002:a05:600c:609b:b0:49c:f9b8:bae0 with SMTP id 5b1f17b1804b1-49fc7f2bdc8mr18281725e9.2.1789722696430; Fri, 18 Sep 2026 02:11:36 -0700 (PDT) Received: from OrangePi5-Plus.BB-HOME (20014C4E1B829B006E521A2A508563A3.dsl.pool.telekom.hu. [2001:4c4e:1b82:9b00:6e52:1a2a:5085:63a3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fc7cfd1dasm37167425e9.9.2026.09.18.02.11.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Sep 2026 02:11:35 -0700 (PDT) From: Igor Paunovic To: Sebastian Reichel Cc: Igor Paunovic , Thinh Nguyen , Greg Kroah-Hartman , Heiko Stuebner , Vinod Koul , Neil Armstrong , Manivannan Sadhasivam , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-phy@lists.infradead.org, kernel@collabora.com Subject: Re: [PATCH 5/5] usb: dwc3: rockchip: fix USB-C reconnect in gadget mode Date: Fri, 18 Sep 2026 11:10:32 +0200 Message-ID: <20260918091032.15593-1-royalnet026@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260915-b4-rockchip-dwc3-rockchip-glue-v1-5-763bb546824e@collabora.com> References: <20260915-b4-rockchip-dwc3-rockchip-glue-v1-5-763bb546824e@collabora.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260918_021140_742613_A421799B X-CRM114-Status: GOOD ( 11.37 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hi Sebastian, With this patch applied, the series fails to build when dwc3 is host-only and USB_GADGET is either disabled, or a module while the glue is built in. I built it on top of v7.3-rc1 for arm64 (allnoconfig plus a fragment, gcc 13.3) with USB=y, USB_DWC3=y, USB_DWC3_HOST=y, USB_DWC3_ROCKCHIP=y and USB_GADGET unset: aarch64-linux-gnu-ld: drivers/usb/dwc3/dwc3-rockchip.o: in function `dwc3_rockchip_set_role': dwc3-rockchip.c:(.text+0x270): undefined reference to `usb_udc_vbus_handler' With USB_DWC3=m and USB_DWC3_ROCKCHIP=m, modpost reports usb_udc_vbus_handler as undefined. With USB_GADGET=m and the glue built in, the link error is the same. With patches 1-4 only, all three configs build. dwc3_rockchip_vbus_handler() checks dwc->gadget only at runtime, so the call to usb_udc_vbus_handler() is always compiled in. That function is only built with USB_GADGET (drivers/usb/gadget/udc/core.c) and has no stub in include/linux/usb/gadget.h, and USB_DWC3_ROCKCHIP does not depend on the gadget side. The same test run also shows that the two EXPORT_TRACEPOINT_SYMBOL_GPL lines in 4/5 fix the modpost error I reported on v14. With them dropped, dwc3=y/glue=m (the v14 case) and dwc3=m/glue=m, both with tracing, fail with the same four undefined tracepoint symbols. This was a build test only; I did not run anything on a board. An LLM assistant wrote the build script and helped draft this mail. Igor _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1DC3BC982DA for ; Fri, 18 Sep 2026 09:11:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=M9lIWpH3MlljTLUyuWF1FZwo6TiRuSurDyYcna9KdPk=; b=EfIGFhmbEjwNHn iHo2vrCYDTUlD5mNlWySpzgAhxbt+54ZH/zGvf7zhHKZs/soEh3irgLpD37/spzIsAdE9jPxdD28f EbFGBZE0NoShWVid5WqXc4TetYNlkdWU8c5NY5uvtoHoUsbLVASBNIS6I+7QU0U8sZ24yuo67J75/ gt/aW9SIvbymU/phet/eWsNve5cBGDilsslJ4YbAFYfhvxyHhFnmcYGlE7BPDDYqXPo1I3wDJ4pGA 9ww1Y36OsvdxJlTBneHS3KoTvNc9RDByr7E3HYIcCMDyR619jvy1lZT6sdD1jqxunNZXBPqPcsjGk jkRO+K4HynySRyc30S8Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7UdG-0000000DtsU-36EL; Fri, 18 Sep 2026 09:11:46 +0000 Received: from mail-wm2-x11.google.com ([2a00:1450:4864:31::11]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7UdA-0000000DtoL-2p33 for linux-phy@lists.infradead.org; Fri, 18 Sep 2026 09:11:42 +0000 Received: by mail-wm2-x11.google.com with SMTP id 5b1f17b1804b1-49c5a927a1fso143695e9.2 for ; Fri, 18 Sep 2026 02:11:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789722697; x=1790327497; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=yZ/vqBSgFHqCJoAqatA3IE2jvlq836FlV9wvuCTBolI=; b=eteVM4DkX2YdJStF8RN9lDBRWoKHT22ScfaP9vhGkY0UguBsFmgxKL0LFMpwUp6Bj1 ps3xCDy0HxFpHis08xgsyjutMryP2SuamgnHdIbVnPF+86tq8lYDK12wagzhY9GLAcdh u3PuRN6MCEtGWIVic1R4ilpQMvjqlFz9Iyk+Kw9W9zb6tAXnospEX6dHh2kj3u6qqxba OFIBJKmZB33aU0jHis0i7/bzdfcmAjJY6gR5CyDXTN42Y/hrpzBZyU3YgoJ4Twtphzms vmY+gkraw63QHwzpROZmCIyzK1lxnbqBtDL1KJQoxJRfKkgQ7n1+XgboBCy8n7mkviPp cjHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789722697; x=1790327497; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=yZ/vqBSgFHqCJoAqatA3IE2jvlq836FlV9wvuCTBolI=; b=P2aEef6VWzdQnCC9qSRIC+dkn6f5td89+HFUKbKdEz+tzuDpjgEtwMAKzAD2lDvDvs w8+ujlU3A+hxmt65NtyOLsUzHFYppyfFGY/94yJ4CrVzISGpWZ+uyAnfzMIuOE8HAtzb Tr6SlVxp+NmkAUTIVfiUO6UBAo5Mjw2+pDHv3rd69VuPAJ3rZhnP1Q9e4zRkKwqb2cWz Ev58BNL9kapwLe+zuyV4BZxxkN5ZFcgTRmBYwxG4LtAvUuok5oz2iXjjtT0wKKcxEOcN xwM+ec8xIW8xtguXiBR2DEu/FZEMGQmgWHWoTPFqYaByMHHE/ZYdADd+JrRo3dajjc4P BluQ== X-Forwarded-Encrypted: i=1; AKwUvByI9OZcf+UZfXSUNOvgtVrI4j3GtoM/Dq0vSQQas0c6MeQ1Ssc2pLHk0M18BxYym8FYzkylW7zGX3c=@lists.infradead.org X-Gm-Message-State: AFuF++lX6kNGW9KMg9ieKspZvlBIdIrN9JH75c56KiDaG5A59Oau5Ysv VvXLxPW1hvVXJ01d0NDjkx0h003YxnZm1m2ua+g1MqKiCATfPecCAG1w X-Gm-Gg: AYBFou06U8lhlkmpmfqRpjc4jy3tUndFhDp8e+4zS5VQ8hu98ZissFs6MUndHY8KZBx qnfWGcJz9LmYveXyga+a6gWzQQzx+Mpsg44zm1S6iFsoWfvFXf9pTlTtHFrZ84Zj4raNypy/1uE zhZCPNDKURPoxJOzX3zm/uKxeVBVm32x0Bub70TJstG0nw4ru55vQVo/1YrtrKqiZK95YmFHdDd XWT76G4rIA180p7N53PekCotcgyEYybxRlOwCxoZYdeG2U+cJYQGK4xgBbbSKMtE0qX3cDv60hF XzPiyXBpGOsHdpFFv0LQKOvJy1yn9WYr04uvWzWXxk3WiCZ6uzJk94wBbMWm5+ZjpzykVShVIqC u0+E4WlFZUEDroDGLfvAmITiBws0UX4swFI6uIMOwNbO8y+NBtKvXNTzASp/XwfTByFeI6sau6f htXn3HrYjvtbLbHDteJA2g4fzSeTbkoNRnhgfpuRKNlf0HdH7GTJnI2NyZH+B2FUQj2dvx10a/z yjTLZRx1/8H8KxtAJXQSPKiChiX86y7VFRz2sgGv4caagQlHDj7jdMxAFJHuf8V1uuHojdjraRI kFX/ X-Received: by 2002:a05:600c:609b:b0:49c:f9b8:bae0 with SMTP id 5b1f17b1804b1-49fc7f2bdc8mr18281725e9.2.1789722696430; Fri, 18 Sep 2026 02:11:36 -0700 (PDT) Received: from OrangePi5-Plus.BB-HOME (20014C4E1B829B006E521A2A508563A3.dsl.pool.telekom.hu. [2001:4c4e:1b82:9b00:6e52:1a2a:5085:63a3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fc7cfd1dasm37167425e9.9.2026.09.18.02.11.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Sep 2026 02:11:35 -0700 (PDT) From: Igor Paunovic To: Sebastian Reichel Cc: Igor Paunovic , Thinh Nguyen , Greg Kroah-Hartman , Heiko Stuebner , Vinod Koul , Neil Armstrong , Manivannan Sadhasivam , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-phy@lists.infradead.org, kernel@collabora.com Subject: Re: [PATCH 5/5] usb: dwc3: rockchip: fix USB-C reconnect in gadget mode Date: Fri, 18 Sep 2026 11:10:32 +0200 Message-ID: <20260918091032.15593-1-royalnet026@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260915-b4-rockchip-dwc3-rockchip-glue-v1-5-763bb546824e@collabora.com> References: <20260915-b4-rockchip-dwc3-rockchip-glue-v1-5-763bb546824e@collabora.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260918_021140_750259_E7DD7135 X-CRM114-Status: GOOD ( 11.16 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Hi Sebastian, With this patch applied, the series fails to build when dwc3 is host-only and USB_GADGET is either disabled, or a module while the glue is built in. I built it on top of v7.3-rc1 for arm64 (allnoconfig plus a fragment, gcc 13.3) with USB=y, USB_DWC3=y, USB_DWC3_HOST=y, USB_DWC3_ROCKCHIP=y and USB_GADGET unset: aarch64-linux-gnu-ld: drivers/usb/dwc3/dwc3-rockchip.o: in function `dwc3_rockchip_set_role': dwc3-rockchip.c:(.text+0x270): undefined reference to `usb_udc_vbus_handler' With USB_DWC3=m and USB_DWC3_ROCKCHIP=m, modpost reports usb_udc_vbus_handler as undefined. With USB_GADGET=m and the glue built in, the link error is the same. With patches 1-4 only, all three configs build. dwc3_rockchip_vbus_handler() checks dwc->gadget only at runtime, so the call to usb_udc_vbus_handler() is always compiled in. That function is only built with USB_GADGET (drivers/usb/gadget/udc/core.c) and has no stub in include/linux/usb/gadget.h, and USB_DWC3_ROCKCHIP does not depend on the gadget side. The same test run also shows that the two EXPORT_TRACEPOINT_SYMBOL_GPL lines in 4/5 fix the modpost error I reported on v14. With them dropped, dwc3=y/glue=m (the v14 case) and dwc3=m/glue=m, both with tracing, fail with the same four undefined tracepoint symbols. This was a build test only; I did not run anything on a board. An LLM assistant wrote the build script and helped draft this mail. Igor -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm2-f13.google.com (mail-wm2-f13.google.com [74.125.225.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81CD236B05E for ; Fri, 18 Sep 2026 09:11:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789722700; cv=none; b=o82y88MIE+vEZRAyZAwDiHWXli0UAKHMBmjfCJLrpK1gcxkkSV3nloHaj7hJHjUnU5+/FYY2ZWPWkD/vFsy2WMFNQj7W71eud5bAYwX3EyXIIYNCV8i5mMQiwLbmF0EmF5Vi3WcsZz/axdtKUbci0C/rsrhn7C2O7Hi9GszdD+I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789722700; c=relaxed/simple; bh=wAiKM2GbjVAaJOG3T4th+tKZWnW5DbfM/sH35qLt13k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aUHAva5VvvUOZAeBMMhuDx8rer7HlAYJ5E8l+HuE3kiHReLJBa7gyS0u2fLJYSJSnw/TLhEasCsaoL5oWXLEf/Lvv9ZLCyn+WuAac4SPIFoevM/akmh5zDEc3y/v/ii+gD1lfgU/5MAlijblND3/wNTYAi6NgIdpbv1aTPXu3Wg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VpCwDl9N; arc=none smtp.client-ip=74.125.225.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VpCwDl9N" Received: by mail-wm2-f13.google.com with SMTP id 5b1f17b1804b1-49b0dd3e1d0so110435e9.0 for ; Fri, 18 Sep 2026 02:11:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789722697; x=1790327497; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=yZ/vqBSgFHqCJoAqatA3IE2jvlq836FlV9wvuCTBolI=; b=VpCwDl9NwhnCzL6tzt1DQO31T0MUc+u9/zaQqGPJuRlPCux2GqE9b1hLgtTRh/HLI+ HlsPIUMSbVxc0Nf4MkFCVWY1hZWQfDu1soDTOGG3kvdn8/4TVNn49qRpMsNxKdrBd+UE 0qnqu1bfvqnLYyS+sA1PRpPaNyGfoI9VcDBhwe5WIh6k8a3Oijv3IHAHYIQtaIGRAFva AaEy55vwoeCHWz47WWdwL697qNdtmf1WTnkdHBviQnqRHxzCCzbo7TXrYQsjzI/BlT6D 3Tlk7wmRheoqqEmqsiA0Hr9GCgEswNEmJA6d5Wjp/aS9Eag7kfxRTiIYcvweOd+xtPdy 9lYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789722697; x=1790327497; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=yZ/vqBSgFHqCJoAqatA3IE2jvlq836FlV9wvuCTBolI=; b=RzsY3MVgiVm93corGHgk1Zo3o19cQbrxdSH2nKmIE6ov37dGo5wlhIeQPWocZL54Bj lENuc7OpNpQCWBd5V9Nv3PH/Y6/yTBS9V8W51w4bUrbGUAeP3q6Dap0CB87aajG3S972 cTkJSN4cZJO+xK5NVpjL/xyT64ANJeWrBSI6V25SP3DXT3pkHu5rPukUpLETiFvhqGZY P8vsaOAJZvpATyOA+kHRMSXlsEDeltquekt4IuQdv/T+aZ7pr5G/BRYtllSt0dZ7Vkxb BcTCO5p0bfwFpcHRFhwxwrbpLqGBtVDJ+O3fmV5UtwVJ+QDMRmqVo45Gedsh7atFdggM 1RAQ== X-Forwarded-Encrypted: i=1; AKwUvBwdBZrc3gxN3QcAIcMJqApSWzytKgndMFuvaGudu0Te0jdY+jOllJrI/4bqX4ZKL2bETi/gE6l3I7o=@vger.kernel.org X-Gm-Message-State: AFuF++nynl9s6iRTN6SHT92W/o9+8uq180HjZRRnzQik/F4apRGHDGjX 6+q8XqYusuFG9UAVAqYk7bZ2/FvFcpuKDI8AwPK26qXMn0m8GGWF3wDS X-Gm-Gg: AYBFou1QC7gwraTUzkS3RBqNqJsMWFcCPUdxK4szuVFdUXQKq4ydPySY3ZKszqCAsjy BfNIO2lxvqm3iWhmuogYeNbE0+sGcxXthrvE3n5zg3f/VAkfOozJEYnfGPCrTQwUZr3FXROaZbE GZKw0VOvVA4HmWV7IYJ8Ni6lpNCkqW2+7CcYseekprpSnEoM5fduONy9oWr5r28nIVdog17BKZh BEZvID30dQpIVXmAVIfYdvln+sHxMdJW6ZNiziBboF69UYeQ1eveT+N/Zu2XZGmbBWC/MW0soET NLwqaE6eYOY+b6gmnFpzpaW8umUVzTMWRl+i7riJB93WLHvFRzmhlxpTr0HAkXZ6B1FRENtB2gU d/eXcvVfJW8APFG+fZX0FJvmBPGDq6DAcgjFrr2TdkTABS6VSDS4/9TWQNv6yhRmSoUpUGQ2mD4 SX1ZOyjbGDaqpNQyn5XgFmjVAS303+kGp7DMlumgKr633lDJdBWgxJhJuOgFit5VHj1+wVZdWPL LLQ7z4wZz655GLzx6d/RK38upfaTI1BS3AA1TUht9aEqnbetQXiWYTR7p9p0sI/oo+aUIqOzH95 d9ON X-Received: by 2002:a05:600c:609b:b0:49c:f9b8:bae0 with SMTP id 5b1f17b1804b1-49fc7f2bdc8mr18281725e9.2.1789722696430; Fri, 18 Sep 2026 02:11:36 -0700 (PDT) Received: from OrangePi5-Plus.BB-HOME (20014C4E1B829B006E521A2A508563A3.dsl.pool.telekom.hu. [2001:4c4e:1b82:9b00:6e52:1a2a:5085:63a3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fc7cfd1dasm37167425e9.9.2026.09.18.02.11.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Sep 2026 02:11:35 -0700 (PDT) From: Igor Paunovic To: Sebastian Reichel Cc: Igor Paunovic , Thinh Nguyen , Greg Kroah-Hartman , Heiko Stuebner , Vinod Koul , Neil Armstrong , Manivannan Sadhasivam , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-phy@lists.infradead.org, kernel@collabora.com Subject: Re: [PATCH 5/5] usb: dwc3: rockchip: fix USB-C reconnect in gadget mode Date: Fri, 18 Sep 2026 11:10:32 +0200 Message-ID: <20260918091032.15593-1-royalnet026@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260915-b4-rockchip-dwc3-rockchip-glue-v1-5-763bb546824e@collabora.com> References: <20260915-b4-rockchip-dwc3-rockchip-glue-v1-5-763bb546824e@collabora.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Sebastian, With this patch applied, the series fails to build when dwc3 is host-only and USB_GADGET is either disabled, or a module while the glue is built in. I built it on top of v7.3-rc1 for arm64 (allnoconfig plus a fragment, gcc 13.3) with USB=y, USB_DWC3=y, USB_DWC3_HOST=y, USB_DWC3_ROCKCHIP=y and USB_GADGET unset: aarch64-linux-gnu-ld: drivers/usb/dwc3/dwc3-rockchip.o: in function `dwc3_rockchip_set_role': dwc3-rockchip.c:(.text+0x270): undefined reference to `usb_udc_vbus_handler' With USB_DWC3=m and USB_DWC3_ROCKCHIP=m, modpost reports usb_udc_vbus_handler as undefined. With USB_GADGET=m and the glue built in, the link error is the same. With patches 1-4 only, all three configs build. dwc3_rockchip_vbus_handler() checks dwc->gadget only at runtime, so the call to usb_udc_vbus_handler() is always compiled in. That function is only built with USB_GADGET (drivers/usb/gadget/udc/core.c) and has no stub in include/linux/usb/gadget.h, and USB_DWC3_ROCKCHIP does not depend on the gadget side. The same test run also shows that the two EXPORT_TRACEPOINT_SYMBOL_GPL lines in 4/5 fix the modpost error I reported on v14. With them dropped, dwc3=y/glue=m (the v14 case) and dwc3=m/glue=m, both with tracing, fail with the same four undefined tracepoint symbols. This was a build test only; I did not run anything on a board. An LLM assistant wrote the build script and helped draft this mail. Igor