Re: [PATCH 12/21] media: i2c: it6625: use unaligned/units helpers to decode pixel clock

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] media: it6625: semantically incorrect constant KHZ_PER_MHZ for unit conversion
--

commit 146d1093ddad76000491939b05b57d1dc7671652
Author: Hermes Wu <Hermes.wu@ite.com.tw>

media: i2c: it6625: use unaligned/units helpers to decode pixel clock

This commit updates the pixel clock decoding in it6625_get_pclk() to use
get_unaligned_be32() and replaces a hardcoded multiplier with a constant
from the units header.

> diff --git a/drivers/media/i2c/it6625.c b/drivers/media/i2c/it6625.c
> index 328bd99f27cf8..60c79a2277941 100644
> --- a/drivers/media/i2c/it6625.c
> +++ b/drivers/media/i2c/it6625.c

[ ... ]

> @@ -633,28 +635,22 @@ static int get_audio_sampling_rate(struct it6625 *it6625)
>  
>  static u64 it6625_get_pclk(struct it6625 *it6625)
>  {

[ ... ]

>  	v4l2_dbg(1, debug, &it6625->sd, "%s: pclk=%u (%08x)",
>  		 __func__, pclk, pclk);
>  
> -	return (u64)pclk * 1000;
> +	return (u64)pclk * KHZ_PER_MHZ;

[Severity: Low]
Is this the correct unit constant for this conversion?

The code in it6625_get_pclk() reads a pixel clock value in kHz and converts
it to Hz. While KHZ_PER_MHZ and HZ_PER_KHZ both evaluate to 1000, using
KHZ_PER_MHZ here is dimensionally incorrect (kHz * (kHz / MHz)).

Should this use HZ_PER_KHZ instead to properly represent the conversion
to Hz?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260918-upstream-it6625-follow-up-patch-v1-0-78d72d7886a5@ite.com.tw?part=12