Re: [PATCH v7 03/11] iio: dac: mcp47feb02: use field_get() instead of custom dynamic macros

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] iio: dac: unused macro MCP47FEB02_DAC_CTRL_MASK left behind
--

commit d3bd49e7115fae14b0ecbbde0aa73b674836dfd2
Author: Ariana Lazar <ariana.lazar@microchip.com>

iio: dac: mcp47feb02: use field_get() instead of custom dynamic macros

This commit replaces manual bit operations for selecting channel-specific
bits with the field_get() macro in mcp47feb02_init_ctrl_regs().

Link: https://lore.kernel.org/all/20260913224339.490d89ba@jic23-hlaptop/

> diff --git a/drivers/iio/dac/mcp47feb02.c b/drivers/iio/dac/mcp47feb02.c
> index 1b1a4972f7719..d910a6cf9718d 100644
> --- a/drivers/iio/dac/mcp47feb02.c
> +++ b/drivers/iio/dac/mcp47feb02.c

[ ... ]

> @@ -1024,7 +1024,7 @@ static int mcp47feb02_init_ctrl_regs(struct mcp47feb02_data *data)
>  			return ret;
>  		data->chdata[i].dac_data = dac_val;
>  
> -		data->chdata[i].ref_mode = (vref_ch >> (2 * i)) & MCP47FEB02_DAC_CTRL_MASK;
> +		data->chdata[i].ref_mode = field_get(DAC_CTRL_MASK(i), vref_ch);

[Severity: Low]
Does this change leave behind MCP47FEB02_DAC_CTRL_MASK as unused dead code?

Since this patch replaces all instances of MCP47FEB02_DAC_CTRL_MASK, should
the original definition be removed from the file to prevent code clutter?

drivers/iio/dac/mcp47feb02.c:
    #define MCP47FEB02_DAC_CTRL_MASK			GENMASK(1, 0)

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260918-mcp47feb02_refactor-v7-0-82ca794eafe2@microchip.com?part=3