From: sashiko-bot@kernel.org
To: "Kieran Bingham" <kieran.bingham@ideasonboard.com>
Cc: wsa+renesas@sang-engineering.com, devicetree@vger.kernel.org,
media-ci@linuxtv.org, imx@lists.linux.dev, conor+dt@kernel.org,
robh@kernel.org, Frank.Li@kernel.org
Subject: Re: [PATCH v5 6/6] dt-bindings: media: i2c: himax,hm1246: Use video-interface-devices
Date: Fri, 18 Sep 2026 10:19:02 +0000 [thread overview]
Message-ID: <20260918101903.7B5E71F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260918-kbingham-orientation-v5-6-e1a134326988@ideasonboard.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: incorrect macro substitution for orientation
--
commit 009f981811cc18f443edfd8ba45e1a412697cced
Author: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
dt-bindings: media: i2c: himax,hm1246: Use video-interface-devices
This commit updates the himax,hm1246 device tree binding example to use
the new video-interface-devices definitions for the orientation property,
replacing the previous hardcoded integer values.
> diff --git a/Documentation/devicetree/bindings/media/i2c/himax,hm1246.yaml b/Documentation/devicetree/bindings/media/i2c/himax,hm1246.yaml
> index a65488fcc643f..ca5817684e1e2 100644
> --- a/Documentation/devicetree/bindings/media/i2c/himax,hm1246.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/himax,hm1246.yaml
[ ... ]
> @@ -103,7 +104,7 @@ examples:
> iovdd-supply = <&hm1246_iovdd>;
> dvdd-supply = <&hm1246_dvdd>;
>
> - orientation = <2>;
> + orientation = <MEDIA_ORIENTATION_FRONT>;
[Severity: Low]
Does this mistakenly change the orientation value in the example?
In dt-bindings/media/video-interface-devices.h, MEDIA_ORIENTATION_FRONT
is defined as 0, while MEDIA_ORIENTATION_EXTERNAL is defined as 2.
Replacing <2> with <MEDIA_ORIENTATION_FRONT> alters the actual value from
External (2) to Front (0) in the device tree example. Should this use
<MEDIA_ORIENTATION_EXTERNAL> instead to maintain a direct macro replacement?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260918-kbingham-orientation-v5-0-e1a134326988@ideasonboard.com?part=6
next prev parent reply other threads:[~2026-09-18 10:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 10:05 [PATCH v5 0/6] dt-bindings: Orientation defines Kieran Bingham
2026-09-18 10:05 ` Kieran Bingham
2026-09-18 10:05 ` [PATCH v5 1/6] arm64: dts: freescale: Convert to new media orientation definitions Kieran Bingham
2026-09-18 10:05 ` Kieran Bingham
2026-09-18 10:05 ` [PATCH v5 2/6] arm64: dts: qcom: " Kieran Bingham
2026-09-18 10:05 ` Kieran Bingham
2026-09-18 10:05 ` [PATCH v5 3/6] arm64: dts: renesas: " Kieran Bingham
2026-09-18 10:05 ` Kieran Bingham
2026-09-18 10:05 ` [PATCH v5 4/6] arm64: dts: rockchip: " Kieran Bingham
2026-09-18 10:05 ` Kieran Bingham
2026-09-18 10:05 ` [PATCH v5 5/6] ARM: tegra: " Kieran Bingham
2026-09-18 10:05 ` Kieran Bingham
2026-09-18 10:05 ` [PATCH v5 6/6] dt-bindings: media: i2c: himax,hm1246: Use video-interface-devices Kieran Bingham
2026-09-18 10:05 ` Kieran Bingham
2026-09-18 10:19 ` sashiko-bot [this message]
2026-09-18 10:38 ` Kieran Bingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260918101903.7B5E71F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=kieran.bingham@ideasonboard.com \
--cc=media-ci@linuxtv.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.