From: Christoph Hellwig <hch@lst.de>
To: Guixin Liu <kanie@linux.alibaba.com>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Nilay Shroff <nilay@linux.ibm.com>,
Daniel Wagner <dwagner@suse.de>,
John Garry <john.g.garry@oracle.com>,
Hannes Reinecke <hare@suse.de>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH 1/2] nvmet: return Invalid Field for invalid NSIDs in Set Features 82h
Date: Fri, 18 Sep 2026 14:05:11 +0200 [thread overview]
Message-ID: <20260918120511.GA16425@lst.de> (raw)
In-Reply-To: <20260918033932.3864965-2-kanie@linux.alibaba.com>
On Fri, Sep 18, 2026 at 11:39:31AM +0800, Guixin Liu wrote:
> - if (status)
> + if (status) {
> + /* 82h is Invalid Field for invalid NSIDs, not Invalid NS */
Overly long line, but I don't this comment is very helpful as-is anyway.
For one mentioning the value while the code uses symbolic names is
confusing, but otherwise it also doesn't really say why we care.
IMHO we can just drop it?
> + if (status == (NVME_SC_INVALID_NS | NVME_STATUS_DNR))
no need for the braces.
> + status = NVME_SC_INVALID_FIELD | NVME_STATUS_DNR;
Another overly long line. Easily fixed by just directly returning:
return NVME_SC_INVALID_FIELD | NVME_STATUS_DNR;
next prev parent reply other threads:[~2026-09-18 12:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 3:39 [PATCH 0/2] nvmet: fix FID 82h status codes for invalid NSIDs Guixin Liu
2026-09-18 3:39 ` [PATCH 1/2] nvmet: return Invalid Field for invalid NSIDs in Set Features 82h Guixin Liu
2026-09-18 12:05 ` Christoph Hellwig [this message]
2026-09-20 1:57 ` Guixin Liu
2026-09-18 3:39 ` [PATCH 2/2] nvmet: return Invalid Field for invalid NSIDs in Get " Guixin Liu
2026-09-18 12:05 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260918120511.GA16425@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=john.g.garry@oracle.com \
--cc=kanie@linux.alibaba.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=nilay@linux.ibm.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.