All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Perale via buildroot <buildroot@buildroot.org>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Thomas Perale <thomas.perale@mind.be>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/intel-mediasdk: add missing BR2_TOOLCHAIN_GCC_AT_LEAST_8 dependency
Date: Fri, 18 Sep 2026 15:08:24 +0200	[thread overview]
Message-ID: <20260918130824.162097-1-thomas.perale@mind.be> (raw)
In-Reply-To: <20260912214557.1572535-1-thomas.petazzoni@bootlin.com>

In reply of:
> BR2_PACKAGE_INTEL_MEDIASDK selects BR2_PACKAGE_INTEL_MEDIADRIVER but
> forgets to propagate the "depends on BR2_TOOLCHAIN_GCC_AT_LEAST_8".
> 
> This issue was introduced in commit
> 51b60c8acf3f4b534d0954b801f1034491b59c94, when "depends on
> BR2_TOOLCHAIN_GCC_AT_LEAST_8" was added to mesa3d, propagated to
> intel-mediadriver, but not intel-mediasdk.
> 
> Fixes: 51b60c8acf3f4b534d0954b801f1034491b59c94 ("package/mesa3d: needs gcc >= 8")
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Applied to 2025.02.x & 2026.08.x. Thanks

> ---
>  package/intel-mediasdk/Config.in | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/package/intel-mediasdk/Config.in b/package/intel-mediasdk/Config.in
> index c1f609e3f8..7738dcbbeb 100644
> --- a/package/intel-mediasdk/Config.in
> +++ b/package/intel-mediasdk/Config.in
> @@ -3,6 +3,7 @@ config BR2_PACKAGE_INTEL_MEDIASDK
>  	depends on BR2_x86_64
>  	depends on !BR2_STATIC_LIBS # intel-mediadriver
>  	depends on BR2_INSTALL_LIBSTDCPP # intel-mediadriver
> +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_8 # intel-mediadriver
>  	depends on BR2_TOOLCHAIN_HAS_SYNC_1 # intel-mediadriver
>  	depends on BR2_TOOLCHAIN_HAS_THREADS # intel-mediadriver
>  	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # intel-mediadriver
> @@ -20,7 +21,8 @@ config BR2_PACKAGE_INTEL_MEDIASDK
>  
>  	  http://mediasdk.intel.com/
>  
> -comment "intel-mediasdk needs a toolchain w/ dynamic library, C++, NPTL"
> +comment "intel-mediasdk needs a toolchain w/ dynamic library, gcc >= 8, C++, NPTL"
>  	depends on BR2_x86_64 && BR2_TOOLCHAIN_HAS_SYNC_1
>  	depends on BR2_STATIC_LIBS || !BR2_INSTALL_LIBSTDCPP || \
> -		!BR2_TOOLCHAIN_HAS_THREADS_NPTL
> +		!BR2_TOOLCHAIN_HAS_THREADS_NPTL || \
> +		!BR2_TOOLCHAIN_GCC_AT_LEAST_8
> -- 
> 2.55.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2026-09-18 13:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-12 21:45 [Buildroot] [PATCH 1/2] package/intel-mediasdk: add missing BR2_TOOLCHAIN_GCC_AT_LEAST_8 dependency Thomas Petazzoni via buildroot
2026-09-12 21:45 ` [Buildroot] [PATCH 2/2] package/intel-vpl-gpu-rt: " Thomas Petazzoni via buildroot
2026-09-13  9:12 ` [Buildroot] [PATCH 1/2] package/intel-mediasdk: " Julien Olivain via buildroot
2026-09-18 13:08 ` Thomas Perale via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260918130824.162097-1-thomas.perale@mind.be \
    --to=buildroot@buildroot.org \
    --cc=thomas.perale@mind.be \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.