Re: [Buildroot] [PATCH] package/kodi: propagate mariadb dependencies to BR2_PACKAGE_KODI_MYSQL

[Thomas Perale via buildroot <buildroot@buildroot.org>]

In reply of:
> Even though kodi itself has architecture dependencies (expressed
> through BR2_PACKAGE_KODI_ARCH_SUPPORTS, the option
> BR2_PACKAGE_KODI_MYSQL selects BR2_PACKAGE_MARIADB, which has its own
> architecture dependencies as well. Make sure to propagate those to
> BR2_PACKAGE_KODI_MYSQL, which doesn't require adding a Config.in
> comment as these are purely architecture dependencies.
> 
> We haven't replicate all dependencies of BR2_PACKAGE_MARIADB because
> all the others are covered by the top-level BR2_PACKAGE_KODI, and
> propagating them would require adding a Config.in comment for
> BR2_PACKAGE_KODI_MYSQL.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Applied to 2025.02.x & 2026.08.x. Thanks

> ---
> We don't have a super clear/strong policy on whether dependencies need
> to be replicated to a sub-option when the package top-level option
> already has them. I haven't done so in this case, but if people feel
> like it should be done, I'll be happy to send an updated patch.
> ---
>  package/kodi/Config.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/kodi/Config.in b/package/kodi/Config.in
> index 08a7caae2c..0b13136d82 100644
> --- a/package/kodi/Config.in
> +++ b/package/kodi/Config.in
> @@ -202,6 +202,7 @@ comment "nfs support needs a toolchain w/ threads support"
>  
>  config BR2_PACKAGE_KODI_MYSQL
>  	bool "mysql"
> +	depends on BR2_TOOLCHAIN_HAS_ATOMIC || BR2_TOOLCHAIN_HAS_SYNC_8 # mariadb
>  	select BR2_PACKAGE_MARIADB
>  	help
>  	  Enable MySQL support
> -- 
> 2.55.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot