All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Perale via buildroot <buildroot@buildroot.org>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Thomas Perale <thomas.perale@mind.be>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/webkitgtk: propagate gst1-libav architecture dependency
Date: Fri, 18 Sep 2026 15:09:07 +0200	[thread overview]
Message-ID: <20260918130907.163101-1-thomas.perale@mind.be> (raw)
In-Reply-To: <20260913170133.1695626-1-thomas.petazzoni@bootlin.com>

In reply of:
> BR2_PACKAGE_WEBKITGTK_MULTIMEDIA selects BR2_PACKAGE_GST1_LIBAV, which
> depends on BR2_PACKAGE_FFMPEG_ARCH_SUPPORTS, but doesn't propagate
> this dependency. In practice, there is no issue, as webkitgtk is only
> available on a subset of CPU architectures, while
> BR2_PACKAGE_FFMPEG_ARCH_SUPPORTS makes ffmpeg available on pretty much
> all CPU architectures, except Cortex-M, m68k coldfire, and some
> specific cases of OpenRISC, which are not supported by webkitgtk.
> 
> But for the sake of having correct dependency propagation, let's fix
> this.
> 
> The other packages selected by BR2_PACKAGE_WEBKITGTK_MULTIMEDIA have
> dependencies that are already handled at the top-level
> BR2_PACKAGE_WEBKITGTK option.
> 
> Fixes: e6e549b9e40d42dbb6a551ecaeb040c1e401f21a ("ffmpeg: add BR2_PACKAGE_FFMPEG_ARCH_SUPPORTS")
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Applied to 2025.02.x & 2026.08.x. Thanks

> ---
>  package/webkitgtk/Config.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/webkitgtk/Config.in b/package/webkitgtk/Config.in
> index cfb05fd0d3..13a65e57dc 100644
> --- a/package/webkitgtk/Config.in
> +++ b/package/webkitgtk/Config.in
> @@ -112,6 +112,7 @@ comment "webkitgtk https support needs a toolchain w/ dynamic library"
>  
>  config BR2_PACKAGE_WEBKITGTK_MULTIMEDIA
>  	bool "multimedia support"
> +	depends on BR2_PACKAGE_FFMPEG_ARCH_SUPPORTS # gst1-libav
>  	select BR2_PACKAGE_GSTREAMER1
>  	select BR2_PACKAGE_GST1_PLUGINS_BAD
>  	select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_DEBUGUTILS
> -- 
> 2.55.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2026-09-18 13:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-13 17:01 [Buildroot] [PATCH] package/webkitgtk: propagate gst1-libav architecture dependency Thomas Petazzoni via buildroot
2026-09-13 19:36 ` Julien Olivain via buildroot
2026-09-18 13:09 ` Thomas Perale via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260918130907.163101-1-thomas.perale@mind.be \
    --to=buildroot@buildroot.org \
    --cc=thomas.perale@mind.be \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.