From: Thomas Perale via buildroot <buildroot@buildroot.org>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc: Thomas Perale <thomas.perale@mind.be>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/pocketpy: fix build without threads
Date: Fri, 18 Sep 2026 15:09:28 +0200 [thread overview]
Message-ID: <20260918130928.163363-1-thomas.perale@mind.be> (raw)
In-Reply-To: <20260907122423.1350497-1-dario.binacchi@amarulasolutions.com>
In reply of:
> pocketpy enables thread support by default (PK_ENABLE_THREADS=ON) and
> then requires Threads from cmake, which fails on toolchains without
> thread support:
>
> CMake Error at /usr/share/cmake-3.28/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
> Could NOT find Threads (missing: Threads_FOUND)
>
> Thread support is optional, so enable it only when the toolchain
> provides threads.
>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Applied to 2026.08.x. Thanks
> ---
> package/pocketpy/pocketpy.mk | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/package/pocketpy/pocketpy.mk b/package/pocketpy/pocketpy.mk
> index 23789dd62028..c1ae075d3897 100644
> --- a/package/pocketpy/pocketpy.mk
> +++ b/package/pocketpy/pocketpy.mk
> @@ -12,6 +12,12 @@ POCKETPY_INSTALL_STAGING = YES
>
> POCKETPY_CONF_OPTS = -DPK_BUILD_SHARED_LIB=ON
>
> +ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
> +POCKETPY_CONF_OPTS += -DPK_ENABLE_THREADS=ON
> +else
> +POCKETPY_CONF_OPTS += -DPK_ENABLE_THREADS=OFF
> +endif
> +
> define POCKETPY_INSTALL_TARGET_CMDS
> $(INSTALL) -D -m 0755 $(@D)/libpocketpy.so* $(TARGET_DIR)/usr/lib
> endef
> --
> 2.43.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2026-09-18 13:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 12:24 [Buildroot] [PATCH 1/2] package/pocketpy: fix build without threads Dario Binacchi
2026-09-07 12:24 ` [Buildroot] [PATCH 2/2] package/pocketpy: bump to version 2.2.0 Dario Binacchi
2026-09-13 16:34 ` [Buildroot] [PATCH 1/2] package/pocketpy: fix build without threads Julien Olivain via buildroot
2026-09-18 13:09 ` Thomas Perale via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260918130928.163363-1-thomas.perale@mind.be \
--to=buildroot@buildroot.org \
--cc=dario.binacchi@amarulasolutions.com \
--cc=thomas.perale@mind.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.