From: Joshua Crofts <joshua.crofts1@gmail.com>
To: "Markus Schneider-Pargmann" <msp@baylibre.com>
Cc: "Marc Kleine-Budde" <mkl@pengutronix.de>,
"Vincent Mailhol" <mailhol@kernel.org>,
<linux-can@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] can: m_can: pci: add missing pm_runtime_dont_use_autosuspend() call
Date: Fri, 18 Sep 2026 13:15:04 +0200 [thread overview]
Message-ID: <20260918131504.00005d2a@gmail.com> (raw)
In-Reply-To: <DLIC0I1VQLHE.13KVAJJ5FUYZN@baylibre.com>
On Fri, 18 Sep 2026 11:24:09 +0200
"Markus Schneider-Pargmann" <msp@baylibre.com> wrote:
> Hi Joshua,
>
> On Wed Sep 16, 2026 at 2:42 PM CEST, Joshua Crofts wrote:
> > m_can_pci_remove() forgets to call pm_runtime_dont_use_autosuspend() on
> > teardown, even though autosuspend is enabled in m_can_pci_probe().
> >
> > Add the missing function call.
> >
>
> Can you please add a Fixes: tag?
I guess it's not a problem, however we had a discussion in the
USB subsystem whether this type of patch is a fix and ended up
agreeing that it's more hardening, hence no Fixes tag.
Alright if I just append the tag here for b4 to collect?
--
Kind regards,
Joshua Crofts
next prev parent reply other threads:[~2026-09-18 11:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 12:42 [PATCH] can: m_can: pci: add missing pm_runtime_dont_use_autosuspend() call Joshua Crofts
2026-09-18 9:24 ` Markus Schneider-Pargmann
2026-09-18 11:15 ` Joshua Crofts [this message]
2026-09-23 7:06 ` Markus Schneider-Pargmann
2026-09-23 7:24 ` Joshua Crofts
2026-09-26 12:52 ` Joshua Crofts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260918131504.00005d2a@gmail.com \
--to=joshua.crofts1@gmail.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol@kernel.org \
--cc=mkl@pengutronix.de \
--cc=msp@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.