Re: [PATCH 3/6] regulator: qcom-pm8008: Add PM8010 mode support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] redundant use of to_i2c_client() when accessing of_node
--

commit f34c6623337a92a1f38e24ae60d1ae6ced8eed2d
Author: Dhruvin Rajpura <drajpura@qti.qualcomm.com>

regulator: qcom-pm8008: Add PM8010 mode support

Implement set_mode/get_mode support for PM8010 LDOs using the mode
control and status registers to allow clients to vote for LDO modes.
Mode voting is not supported in the PM8008 LDOs.

> diff --git a/drivers/regulator/qcom-pm8008-regulator.c b/drivers/regulator/qcom-pm8008-regulator.c
> index b484c0f73eeac..9758809a6322d 100644
> --- a/drivers/regulator/qcom-pm8008-regulator.c
> +++ b/drivers/regulator/qcom-pm8008-regulator.c

[ ... ]

> @@ -169,6 +237,9 @@ static int pm8008_regulator_probe(struct platform_device *pdev)
>  	if (!regmap)
>  		return -EINVAL;
>  
> +	is_pm8010 = of_device_is_compatible(to_i2c_client(dev->parent)->dev.of_node,
> +					    "qcom,pm8010-i2c");
> +

[Severity: Low]
Is there a reason to use to_i2c_client() when accessing of_node in
pm8008_regulator_probe()?

Since to_i2c_client() is defined as container_of(d, struct i2c_client, dev),
accessing the dev member of the resulting structure evaluates back to the
exact original pointer (dev->parent).

The expression to_i2c_client(dev->parent)->dev.of_node is functionally
identical to simply using dev->parent->of_node, making the macro usage
entirely redundant.

>  	for (i = 0; i < match_data->num_regulators; i++) {
>  		data = &match_data->regulator_data[i];

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260918-pm8010_i2c_support-v1-0-de33d78fad9d@oss.qualcomm.com?part=3