From: Jakub Kicinski <kuba@kernel.org>
To: Guangshuo Li <lgs201920130244@gmail.com>
Cc: "Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Petr Machata" <petrm@nvidia.com>,
"Aleksandr Loktionov" <aleksandr.loktionov@intel.com>,
"Jacob Keller" <jacob.e.keller@intel.com>,
"Jijie Shao" <shaojijie@huawei.com>,
"Uwe Kleine-König (The Capable Hub)"
<u.kleine-koenig@baylibre.com>,
"Ruoyu Wang" <ruoyuw560@gmail.com>,
"Jakub Raczynski" <j.raczynski@samsung.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] net: sungem: disable PCI device on remove
Date: Fri, 18 Sep 2026 16:54:37 -0700 [thread overview]
Message-ID: <20260918165437.196b057c@kernel.org> (raw)
In-Reply-To: <20260916055913.2910349-1-lgs201920130244@gmail.com>
On Wed, 16 Sep 2026 13:59:13 +0800 Guangshuo Li wrote:
> gem_init_one() enables the PCI device with pci_enable_device().
>
> The probe failure path balances this operation with
> pci_disable_device(). However, after a successful probe,
> gem_remove_one() releases the PCI resources and netdev without
> disabling the PCI device.
We don't accept trivial fixes to obsolete drivers.
prev parent reply other threads:[~2026-09-18 23:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 5:59 [PATCH] net: sungem: disable PCI device on remove Guangshuo Li
2026-09-16 10:33 ` Loktionov, Aleksandr
2026-09-17 9:01 ` netdev-bot+sashiko
2026-09-18 23:54 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260918165437.196b057c@kernel.org \
--to=kuba@kernel.org \
--cc=aleksandr.loktionov@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=j.raczynski@samsung.com \
--cc=jacob.e.keller@intel.com \
--cc=lgs201920130244@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=ruoyuw560@gmail.com \
--cc=shaojijie@huawei.com \
--cc=stable@vger.kernel.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.