Re: [PATCH] cgroup: Use %p for pointer formatting

[Sebastian Andrzej Siewior <bigeasy@linutronix.de>]

On 2026-09-18 14:59:00 [+0200], Michal Koutný wrote:
> On Fri, Sep 18, 2026 at 12:48:52PM +0200, Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
> > Since commit ad67b74d2469d ("printk: hash addresses printed with
> > %p") pointers are hashed by default and the behaviour can be controller
> > by `hash_pointers' boot argument.
> > The policy on %p is to not introduce new ones.
>                 %pK  should be here?

No, %p was intended. By making it %p it is "introducing" it. The "not
introducing new ones" is based on
  https://docs.kernel.org/process/deprecated.html#p-format-specifier

> I assume it based on:
> 
> | This is because %pK checks are done at read() time rather than open()
> | ...
> | The correct long-term solution is to do the permission checks at
> | open() time.
> 
> of Documentation/admin-guide/sysctl/kernel.rst-time

These checks never came. I need to update that file as well…

> <snip>
> > Removing %pK makes it possible to remove its handling from the library.
> 
> This is also a good sell.
> But I see there are a few of them still here and there.

I am working on it ;) I just sent all code patches and networking
has it applied in -next. So it is moving.

> > 
> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> > ---
> >  kernel/cgroup/debug.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> >
> 
> Nevertheless,
> Acked-by: Michal Koutný <mkoutny@suse.com>

Thank you.

Sebastian