Re: [PATCHv2] dmaengine: bestcomm: Enable compile testing

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] kconfig: missing PPC_MPC52xx dependency for SND_SOC_MPC5200_AC97
--

commit 95cb68468081de8e2880323cb63c64d9da8626b0
Author: Rosen Penev <rosenp@gmail.com>

dmaengine: bestcomm: Enable compile testing

This commit relaxing the dependency for the BestComm DMA engine allows it to
be selected on PowerPC for compile-test builds. It adds an alternative
dependency on (PPC && COMPILE_TEST).

> diff --git a/drivers/dma/bestcomm/Kconfig b/drivers/dma/bestcomm/Kconfig
> index 5dd437295964d..e23ba4982d7ed 100644
> --- a/drivers/dma/bestcomm/Kconfig
> +++ b/drivers/dma/bestcomm/Kconfig
> @@ -5,7 +5,7 @@
>  
>  config PPC_BESTCOMM
>  	tristate "Bestcomm DMA engine support"
> -	depends on PPC_MPC52xx
> +	depends on PPC_MPC52xx || (PPC && COMPILE_TEST)

[Severity: Low]
Does relaxing this dependency cause an unresolved symbol during link time for
SND_SOC_MPC5200_AC97?

When COMPILE_TEST is enabled on PowerPC, PPC_BESTCOMM can be selected without
PPC_MPC52xx. However, SND_SOC_MPC5200_AC97 in sound/soc/fsl/Kconfig depends
on PPC_BESTCOMM but lacks an explicit dependency on PPC_MPC52xx:

sound/soc/fsl/Kconfig:
    config SND_SOC_MPC5200_AC97
        tristate "Freescale MPC5200 PSC in AC97 mode driver"
        depends on PPC_BESTCOMM

This inherits PPC_BESTCOMM's relaxation and allows the driver to be built
when the platform code is absent. In psc_ac97_cold_reset(), the driver
unconditionally calls a platform function:

sound/soc/fsl/mpc5200_psc_ac97.c:psc_ac97_cold_reset() {
    ...
        mpc5200_psc_ac97_gpio_reset(psc_dma->id);
    ...
}

Since mpc5200_psc_ac97_gpio_reset() is only compiled when PPC_MPC52xx is
enabled, does this result in an undefined reference at link time?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260918175950.21657-1-rosenp@gmail.com?part=1