Re: [PATCH net 4/7] net/mlx5e: macsec: Track hardware object ownership for SA teardown

[sashiko-bot@kernel.org]

> From: Cosmin Ratiu <cratiu@nvidia.com>
> 
> A driver MACsec SA can exist without a hardware MACsec object. Adding
> an inactive RX SA or a TX SA while the SecY is non-operational creates
> the encryption key but skips MACsec object creation. RX SA deactivation
> also destroys the hardware object while retaining the driver SA and
> its object ID.
> 
> TX SA deletion and the SA teardown performed by RX SC and SecY deletion
> unconditionally destroy the hardware object. This can issue a destroy
> command with an unallocated zero ID or an ID that has already been
> destroyed and potentially reused. Failed RX SA activation can leave
> the same stale-ID state after steering creation unwinds.
> 
> Track hardware object creation separately from SA activity. Set the
> ownership flag after successful creation, clear it on destruction and
> creation unwind, and check it before destroying the object during SA
> cleanup. This preserves destruction of objects retained by inactive
> TX SAs while avoiding destruction of unowned objects.
> 
> Fixes: 8ff0ac5be144 ("net/mlx5: Add MACsec offload Tx command support")
> Fixes: aae3454e4d4c ("net/mlx5e: Add MACsec offload Rx command support")
> Signed-off-by: Cosmin Ratiu <cratiu@nvidia.com>
> Reviewed-by: Dragos Tatulea <dtatulea@nvidia.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260917175433.4090878-1-tariqt@nvidia.com?part=4