Re: [PATCH v4] dt-bindings: iio: adc: Add dt binding to xlnx,xadc

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: validation bypass when 'xlnx,external-mux' is omitted
--

commit 28ac615c3320e6e0d6b6715f4d23365bf3a32842
Author: Omer PALA <palaomer100@gmail.com>

dt-bindings: iio: adc: Add dt binding to xlnx,xadc

This commit converts the xilinx-xadc.txt device tree binding to YAML format
for xlnx,zynq-xadc-1.00.a, xlnx,axi-xadc-1.00.a, and
xlnx,system-management-wiz-1.3.

> diff --git a/Documentation/devicetree/bindings/iio/adc/xlnx,xadc.yaml b/Documentation/devicetree/bindings/iio/adc/xlnx,xadc.yaml
> new file mode 100644
> index 0000000000000..388511476ca8c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/xlnx,xadc.yaml
[ ... ]
> +allOf:
> +  - if:
> +      not:
> +        properties:
> +          xlnx,external-mux:
> +            enum: [single, dual]
> +    then:
> +      properties:
> +        xlnx,external-mux-channel: false

[Severity: Medium]
Will this logic correctly handle the case where xlnx,external-mux is completely
omitted?

In JSON schema, checking properties without making them required trivially
evaluates to true if the property is missing. This means if xlnx,external-mux
is omitted, the properties check passes, the not keyword inverts it to false,
and the if condition fails.

Because the condition fails, the then clause is skipped entirely, which
seems to allow device trees to specify xlnx,external-mux-channel even when
xlnx,external-mux is not present.

Does this logic bypass the validation the commit is trying to enforce?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260918194434.9240-1-palaomer100@gmail.com?part=1