Re: [PATCH v3 2/4] regulator: dt-bindings: nvidia,tegra-regulators-coupling: Convert to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: example properties are bypassed during schema validation
--

commit 6fc294a8a0e1ff8d45fed563be8b2e544b6e1cc3
Author: Bhargav Joshi <j.bhargav.u@gmail.com>

regulator: dt-bindings: nvidia,tegra-regulators-coupling: Convert to DT schema
    
Convert NVIDIA Tegra Regulators Coupling from legacy text to DT schema.
Set additionalProperties true as this is shared schema.

> diff --git a/Documentation/devicetree/bindings/regulator/nvidia,tegra-regulators-coupling.yaml b/Documentation/devicetree/bindings/regulator/nvidia,tegra-regulators-coupling.yaml
> new file mode 100644
> index 0000000000000..aae951cdce8ba
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/nvidia,tegra-regulators-coupling.yaml
[ ... ]
> +examples:
> +  - |
> +    pmic {
> +        regulators {

[Severity: Low]
Since the example encapsulates the regulator nodes inside 'pmic' and
'regulators' parent nodes, and the schema lacks a selection mechanism for these
subnodes while allowing 'additionalProperties: true', will the validation tool
only check the root 'pmic' node?

This causes the actual 'nvidia,tegra-*-regulator' properties defined in
the subnodes to be ignored by dt_binding_check. Wrapping the nodes prevents
the root-level schema from validating the properties within the specific
regulator nodes.

> +            core_vdd_reg: core {
> +                regulator-name = "vdd_core";
> +                regulator-min-microvolt = <950000>;
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260919-ti-tps6586x-v3-0-63dd240f4684@gmail.com?part=2