From: sashiko-bot@kernel.org
To: "Yury Murashka" <yurypm@arista.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: pciehp: Add PLX quirk for missing Command Completed events
Date: Fri, 18 Sep 2026 21:23:43 +0000 [thread overview]
Message-ID: <20260918212343.D98451F00898@smtp.kernel.org> (raw)
In-Reply-To: <20260918211926.1480-1-yurypm@arista.com>
> All PLX PEX 8600- and 8700-series data books say the Command Completed bit
> is set only after the Hot Plug Controller completes a command that changes
> the Attention Indicator Control, Power Indicator Control, Power Controller
> Control, or Electromechanical Interlock Control fields. It is not set
> after writes that only change the Presence Detect Changed Enable or Command
> Completed Interrupt Enable bits.
>
> Consequently, pciehp waits for Command Completed after changing these
> notification Enable bits and logs a timeout.
>
> This behavior exactly matches the conditions described when
> quirk_cmd_compl() was first added: both controllers report completion only
> when the same four Control fields change and fail to report completion for
> notification Enable-only writes.
>
> Add only the PLX PEX 8600- and 8700-series switches on which this fix was
> tested to quirk_cmd_compl(). This makes pciehp mark Enable-only writes
> complete immediately while continuing to wait for commands that change
> Control fields.
>
> Signed-off-by: Yury Murashka <yurypm@arista.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260918211926.1480-1-yurypm@arista.com?part=1
prev parent reply other threads:[~2026-09-18 21:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 21:19 [PATCH] PCI: pciehp: Add PLX quirk for missing Command Completed events Yury Murashka
2026-09-18 21:23 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260918212343.D98451F00898@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=yurypm@arista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.