From: "Paul E. McKenney" <paulmck@kernel.org>
To: rcu@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: kernel-team@meta.com,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Boqun Feng <boqun@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
lkmm@lists.linux.dev, Zqiang <qiang.zhang@linux.dev>,
Wang Lian <lianux.mm@gmail.com>,
Kunwu Chan <kunwu.chan@gmail.com>,
Bradley Morgan <brads@mainlining.org>,
"Paul E. McKenney" <paulmck@kernel.org>
Subject: [PATCH 09/28] hazptrtorture: Split hazptr_torture_reader_tail() from hazptr_torture_reader()
Date: Fri, 18 Sep 2026 17:00:37 -0700 [thread overview]
Message-ID: <20260919000056.3132131-9-paulmck@kernel.org> (raw)
In-Reply-To: <e9669b34-12c2-4cf2-a887-315f581f0789@paulmck-laptop>
This commit splits a new hazptr_torture_reader_tail() function out
of hazptr_torture_reader(). This will allow hazptr_torture_reader()
to pass hazard pointers off to other tasks and to various types of
handlers, and those hazard pointers can in turn be passed to this new
hazptr_torture_reader_tail() function to complete processing.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Boqun Feng <boqun@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: <rcu@vger.kernel.org>
Cc: <lkmm@lists.linux.dev>
---
kernel/rcu/hazptrtorture.c | 42 +++++++++++++++++++++++++-------------
1 file changed, 28 insertions(+), 14 deletions(-)
diff --git a/kernel/rcu/hazptrtorture.c b/kernel/rcu/hazptrtorture.c
index c0ebabdcc72e..8672169f7868 100644
--- a/kernel/rcu/hazptrtorture.c
+++ b/kernel/rcu/hazptrtorture.c
@@ -351,6 +351,31 @@ hazptr_torture_writer(void *arg)
return 0;
}
+/*
+ * Do the delay, the accounting, and the release. This in intended to
+ * be invoked from hazptr_torture_reader, but also for hazard pointers
+ * sent off to interrupt handlers and the like.
+ */
+static void hazptr_torture_reader_tail(struct hazptr_ctx *hcp, struct hazptr_torture *htp,
+ struct torture_random_state *trsp)
+{
+ int pipe_count;
+
+ cur_ops->read_delay(trsp);
+ preempt_disable();
+ pipe_count = READ_ONCE(htp->htort_pipe_count);
+ if (pipe_count > HAZPTR_TORTURE_PIPE_LEN) {
+ // Should not happen in a correct hazptr implementation,
+ // happens quite often for TBD torture_type=busted.
+ pipe_count = HAZPTR_TORTURE_PIPE_LEN;
+ }
+ if (pipe_count > 1)
+ rcu_ftrace_dump(DUMP_ALL);
+ __this_cpu_inc(hazptr_torture_count[pipe_count]);
+ preempt_enable();
+ cur_ops->readunlock(hcp, htp);
+}
+
/*
* Hazard-pointer torture reader kthread. Repeatedly dereferences
* hazptr_torture_current, incrementing the corresponding element of the
@@ -365,7 +390,6 @@ static int hazptr_torture_reader(void *arg)
unsigned long lastsleep = jiffies;
long myid = (long)arg;
int mynumonline = myid % nr_cpu_ids;
- int pipe_count;
DEFINE_TORTURE_RANDOM(rand);
VERBOSE_TOROUT_STRING("hazptr_torture_reader task started");
@@ -373,6 +397,8 @@ static int hazptr_torture_reader(void *arg)
do {
htp = cur_ops->readlock(&hcp);
if (!htp) {
+ // Still starting up or allocation failure,
+ // so get out of the way.
schedule_timeout_interruptible(HZ / 10);
continue;
}
@@ -380,19 +406,7 @@ static int hazptr_torture_reader(void *arg)
torture_hrtimeout_us(500, 1000, &rand);
lastsleep = jiffies + 10;
}
- cur_ops->read_delay(&rand);
- preempt_disable();
- pipe_count = READ_ONCE(htp->htort_pipe_count);
- if (pipe_count > HAZPTR_TORTURE_PIPE_LEN) {
- // Should not happen in a correct RCU implementation,
- // happens quite often for torture_type=busted.
- pipe_count = HAZPTR_TORTURE_PIPE_LEN;
- }
- if (pipe_count > 1)
- rcu_ftrace_dump(DUMP_ALL);
- __this_cpu_inc(hazptr_torture_count[pipe_count]);
- preempt_enable();
- cur_ops->readunlock(hcp, htp);
+ hazptr_torture_reader_tail(hcp, htp, &rand);
while (!torture_must_stop() &&
(torture_num_online_cpus() < mynumonline || !rcu_inkernel_boot_has_ended()))
schedule_timeout_interruptible(HZ / 5);
--
2.40.1
next prev parent reply other threads:[~2026-09-19 0:01 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 23:59 [PATCH RFC v3 0/28] Simple hazard-pointer implementation and torture tests Paul E. McKenney
2026-09-19 0:00 ` [PATCH 01/28] hazptr: Implement Hazard Pointers Paul E. McKenney
2026-09-19 11:12 ` Bradley Morgan
2026-09-19 16:30 ` Linus Torvalds
2026-09-19 16:34 ` Bradley Morgan
2026-09-19 17:00 ` Linus Torvalds
2026-09-19 17:09 ` Mathieu Desnoyers
2026-09-19 18:09 ` Boqun Feng
2026-09-19 17:19 ` Mathieu Desnoyers
2026-09-19 18:18 ` Paul E. McKenney
2026-09-19 23:58 ` Bradley Morgan
2026-09-19 16:41 ` Bradley Morgan
2026-09-19 17:56 ` Paul E. McKenney
2026-09-19 0:00 ` [PATCH 02/28] hazptr: Add refscale test Paul E. McKenney
2026-09-19 0:00 ` [PATCH 03/28] torture: Add a hazptrtorture.c torture test Paul E. McKenney
2026-09-19 0:00 ` [PATCH 04/28] hazptrtorture: Add testing of on-stack hazptr_ctx structures Paul E. McKenney
2026-09-19 0:00 ` [PATCH 05/28] hazptrtorture: Add microsecond-scale sleep in readers Paul E. McKenney
2026-09-19 0:00 ` [PATCH 06/28] hazptrtorture: Enable system-independent CPU overcommit Paul E. McKenney
2026-09-19 0:00 ` [PATCH 07/28] torture: Add a stutter_will_wait() function Paul E. McKenney
2026-09-19 0:00 ` [PATCH 08/28] hazptrtorture: Use mnemonic local variables for context information Paul E. McKenney
2026-09-19 0:00 ` Paul E. McKenney [this message]
2026-09-19 0:00 ` [PATCH 10/28] hazptrtorture: Add kthread to release deferred hazard pointers Paul E. McKenney
2026-09-19 0:00 ` [PATCH 11/28] hazptrtorture: Defer release of " Paul E. McKenney
2026-09-19 0:00 ` [PATCH 12/28] hazptrtorture: Add irq_acquire to acquire hazptr from irq Paul E. McKenney
2026-09-19 0:00 ` [PATCH 13/28] hazptrtorture: Use task_state_to_char() for task-state reporting Paul E. McKenney
2026-09-19 0:00 ` [PATCH 14/28] hazptrtorture: Pass hazptr_pending to hazptr_torture_reader_tail() Paul E. McKenney
2026-09-19 0:00 ` [PATCH 15/28] hazptrtorture: Add the ability to disable the writer kthread Paul E. McKenney
2026-09-19 0:00 ` [PATCH 16/28] hazptrtorture: Add irq_release to release hazptr from irq Paul E. McKenney
2026-09-19 0:00 ` [PATCH 17/28] hazptrtorture: Accumulate operation statistics Paul E. McKenney
2026-09-19 0:00 ` [PATCH 18/28] doc: Add hazptrtorture module parameters Paul E. McKenney
2026-09-19 0:00 ` [PATCH 19/28] hazptr: Permit detaching hazard pointers from contexts Paul E. McKenney
2026-09-19 11:42 ` Boqun Feng
2026-09-19 11:43 ` Boqun Feng
2026-09-19 0:00 ` [PATCH 20/28] hazptrtorture: Detach deferred and IPIed hazard pointers Paul E. McKenney
2026-09-19 0:00 ` [PATCH 21/28] hazptr: Introduce CONFIG_HAZPTR_DEBUG misuse detection Paul E. McKenney
2026-09-19 0:00 ` [PATCH 22/28] hazptrtorture: Fix hazptr ownership issue Paul E. McKenney
2026-09-19 0:00 ` [PATCH 23/28] hazptrtorture: Enable CONFIG_HAZPTR_DEBUG Paul E. McKenney
2026-09-19 0:00 ` [PATCH 24/28] hazptr: Upgrade kernel-doc headers Paul E. McKenney
2026-09-19 0:00 ` [PATCH 25/28] hazptrtorture: Fix inverted sleep condition in do_pending kthread Paul E. McKenney
2026-09-19 0:00 ` [PATCH 26/28] hazptr: Implement two-phase wildcard scan Paul E. McKenney
2026-09-19 13:28 ` Boqun Feng
2026-09-20 12:46 ` Mathieu Desnoyers
2026-09-20 15:55 ` Boqun Feng
2026-09-25 19:08 ` Mathieu Desnoyers
2026-09-20 14:46 ` Gary Guo
2026-09-20 15:44 ` Mathieu Desnoyers
2026-09-20 15:57 ` Gary Guo
2026-09-25 19:19 ` Mathieu Desnoyers
2026-09-25 20:17 ` Gary Guo
2026-09-25 20:18 ` Mathieu Desnoyers
2026-09-19 0:00 ` [PATCH 27/28] hazptr: handle NULL address in hazptr_detach Paul E. McKenney
2026-09-19 0:00 ` [PATCH 28/28] torture.sh: Add hazptr torturing Paul E. McKenney
2026-09-19 11:18 ` Bradley Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260919000056.3132131-9-paulmck@kernel.org \
--to=paulmck@kernel.org \
--cc=boqun@kernel.org \
--cc=brads@mainlining.org \
--cc=kernel-team@meta.com \
--cc=kunwu.chan@gmail.com \
--cc=lianux.mm@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkmm@lists.linux.dev \
--cc=mathieu.desnoyers@efficios.com \
--cc=qiang.zhang@linux.dev \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.