Re: [PATCH v2 2/2] tests/functional/ppc64: extend ppc64 powernv net device tests

[Amit Machhiwal <amachhiw@linux.ibm.com>]

On 2026/09/16 04:06 PM, Aniket Sahu wrote:
> Added console checks as the probe log lines will appear before the
> S14Silence-console init scripts.

Please add your missing SOB.  The changes look good to me.

Reviewed-by: Amit Machhiwal <amachhiw@linux.ibm.com>

Thanks,
Amit

> ---
>  tests/functional/ppc64/test_powernv.py | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/functional/ppc64/test_powernv.py b/tests/functional/ppc64/test_powernv.py
> index f3e05e4d38..200fd2c894 100755
> --- a/tests/functional/ppc64/test_powernv.py
> +++ b/tests/functional/ppc64/test_powernv.py
> @@ -201,9 +201,12 @@ def do_test_ppc64_powernv(self, proc):
>  
>          self.wait_for_console_pattern("CPU: " + proc + " generation processor")
>          self.wait_for_console_pattern("INIT: Starting kernel at ")
> +        # NVMe, e1000e, and xHCI are probed synchronously by the kernel
> +        # during PCI enumeration, after OPAL hands off to Linux.
> +        self.wait_for_console_pattern("nvme nvme0")
> +        self.wait_for_console_pattern("e1000e")
> +        self.wait_for_console_pattern("xhci_hcd")
>          self.wait_for_console_pattern("Run /sbin/init as init process")
> -        # Device detection output driven by udev probing is sometimes cut off
> -        # from console output, suspect S14silence-console init script.
>  
>      def test_ppc64_powernv_external_dtb(self):
>          self.set_machine('powernv11')
> -- 
> 2.52.0
> 
>