Re: [PATCH v8 07/12] mips: Get rid of custom mips ABIs for syscall tables

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] perf: Unsynchronized MIPS syscall table causes build warning
--

commit 2ce69c55f672c9600f10db5f1b61c39c0604b9a1
Author: André Almeida <andrealmeid@igalia.com>
mips: Get rid of custom mips ABIs for syscall tables

This commit replaces the MIPS-exclusive ABI names (n32, o32, n64) with the
standard "common" ABI name in the MIPS syscall tables. It simplifies and 
unifies the tables without altering functionality.

> diff --git a/arch/mips/kernel/syscalls/syscall_n64.tbl b/arch/mips/kernel/syscalls/syscall_n64.tbl
> index 83dc93a0712f1..4341b2fd96dad 100644
> --- a/arch/mips/kernel/syscalls/syscall_n64.tbl
> +++ b/arch/mips/kernel/syscalls/syscall_n64.tbl
> @@ -5,385 +5,385 @@
>  # The format is:
>  # <number> <abi> <name> <entry point>
>  #
> -# The <abi> is always "n64" for this file.
> +# The <abi> is always "common" for this file.
>  #
> -0	n64	read				sys_read
> +0	common	read				sys_read

[Severity: Low]
Does changing the ABI field to common here without a corresponding update 
in tools/perf cause a build warning?

It looks like building perf will trigger a "Kernel ABI header differences" 
warning from the check-headers.sh script because the synchronized copy at 
tools/perf/arch/mips/entry/syscalls/syscall_n64.tbl was not updated to 
match this tree.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260918-tonyk-syscall_table-v8-0-0e2d60cad13e@igalia.com?part=7