From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 367A919CCF5 for ; Sat, 19 Sep 2026 03:10:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789787402; cv=none; b=nZwlArW4phfqFQajDXNEwWXau0tAUJGzvJlIuEsphy2hgkHyRkyOeC1SgTOQnng0tMarA9jv+xqEgVsS1z7JgVAhoewsDs+xS/Q+F0bPryHorzswvRvPUZeIZHAduskOZWwqV2vm8zBaPfOmW3c7DArHmJos+B1fTjpwFJ5vqm8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789787402; c=relaxed/simple; bh=QuI/0fZazicxeL0JDcw1YWuFmYgB4z0jQlkOH2Bs/wk=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=mmRS0oX9OhGQsd4pQW1fpJ1pXjzl1Li/lyqSxcc7iuNjaAjPLB6fffzM+aVgCNQ+0iWGt3sLAIFDu2PF5X+XZug9Wqqw0SnzbKdkuR1DlVxIlsGm85YK8N/cO7WrvFXNkxHaZ4vGJFC3uXtPz03ILA+ZAjnx2ddGGwqO6iLeiqQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=F3BTCSEV; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="F3BTCSEV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7508D1F000FF; Sat, 19 Sep 2026 03:10:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789787400; bh=CnZRCQ4LtDlcZTqFqNuZYRfqo5vfTpZk6e8tfOnjkdE=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=F3BTCSEVaG+L94JWQ9RDbYO/omyavFleBDe56rOINgSKyeKunH6G+ipfND0kSA7H2 j+Yg/alQuCk8WLqXXNU6AjFFsk/Dj33Q40spyqf2LUQ7L4+HgtHXTewokxt/ali8Xc J+F+lnSj3cJTY72eStDi31UeqZnpAkgZXOmmZC7RR9idyttQbiX/Yko2xQHRn3eiO4 QSN3LDZ2uu/2ETMLIJb6xMvezILkF6HQrFJGtw9Ct8x20iZoM8Qg+JCVVhOnAs7fpX aV68g8/2xFYFXEI8gySEkNO0WM3Z96YMnXpgElwW/r1XPpXbPHAphsA4ItjWzrxQPV BNu45QvhJzuPA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 1/2] dt-bindings: misc: convert axis-fifo binding to YAML Reply-To: sashiko-reviews@lists.linux.dev To: Daniel28972897 Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org In-Reply-To: <20260919025900.169703-2-danyboy28sep@gmail.com> References: <20260919011417.156828-1-danyboy28sep@gmail.com> <20260919025900.169703-1-danyboy28sep@gmail.com> <20260919025900.169703-2-danyboy28sep@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Sat, 19 Sep 2026 03:09:59 +0000 Message-Id: <20260919031000.7508D1F000FF@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] dt-bindings: missing type definition for vendor properties -- commit e279d5a2991ae1467a7af717115f8a8656d5f101 Author: Daniel28972897 dt-bindings: misc: convert axis-fifo binding to YAML This commit converts the text-based axis-fifo binding to a YAML schema to enable validation via dtbs_check. It preserves all original properties, including those generated by the Xilinx IP integrator that are currently ignored by the Linux driver. > diff --git a/Documentation/devicetree/bindings/misc/xlnx,axi-fifo-mm-s.ya= ml b/Documentation/devicetree/bindings/misc/xlnx,axi-fifo-mm-s.yaml > new file mode 100644 > index 0000000000000..fffd69b128111 > --- /dev/null > +++ b/Documentation/devicetree/bindings/misc/xlnx,axi-fifo-mm-s.yaml [ ... ] > + # The following properties are generated by the Xilinx IP integrator > + # for this core and may be present in real-world devicetrees, but are > + # not currently read by the Linux driver. > + xlnx,axi-str-rxd-protocol: true > + xlnx,axi-str-txc-protocol: true > + xlnx,axi-str-txc-tdata-width: true > + xlnx,axi-str-txd-protocol: true > + xlnx,axis-tdest-width: true > + xlnx,axis-tid-width: true [Severity: Low] Does this properties block in Documentation/devicetree/bindings/misc/xlnx,axi-fifo-mm-s.yaml pass make dt_binding_check? The dtschema meta-schema requires all custom vendor-specific properties to have an explicitly defined type constraint (e.g., $ref: /schemas/types.yaml#/definitions/uint32). Setting these vendor properties to true without mandatory $ref type definitions or descriptions causes a build-time validation failure when running make dt_binding_check on the added schema. Will these properties be updated to include the appropriate type constraint= s? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260919025900.1697= 03-1-danyboy28sep@gmail.com?part=3D1