[PATCH v5 2/7] drm/xe/guc: Handle CRASH and EXCEPTION G2H with separate helpers

[Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>]

Refactor to handle the CRASH and EXCEPTION G2H separately. In the
process drop the else case that existed earlier but was unreachable
code.

Suggested-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
---
v2: return 0 from the helpers to retain old behavior (Sashiko)
---
 drivers/gpu/drm/xe/xe_guc_ct.c | 24 +++++++++++++-----------
 1 file changed, 13 insertions(+), 11 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_guc_ct.c b/drivers/gpu/drm/xe/xe_guc_ct.c
index 5c4733da385c..b3a6aa37808b 100644
--- a/drivers/gpu/drm/xe/xe_guc_ct.c
+++ b/drivers/gpu/drm/xe/xe_guc_ct.c
@@ -1553,22 +1553,22 @@ static int parse_g2h_event(struct xe_guc_ct *ct, u32 *msg, u32 len)
 	return 0;
 }
 
-static int guc_crash_process_msg(struct xe_guc_ct *ct, u32 action)
+static int guc_handle_crash_dump_msg(struct xe_guc_ct *ct, u32 action)
 {
-	struct xe_gt *gt = ct_to_gt(ct);
+	xe_gt_err(ct_to_gt(ct), "GuC Crash dump notification\n");
+	CT_DEAD(ct, NULL, CRASH);
+	kick_reset(ct);
 
-	if (action == XE_GUC_ACTION_NOTIFY_CRASH_DUMP_POSTED)
-		xe_gt_err(gt, "GuC Crash dump notification\n");
-	else if (action == XE_GUC_ACTION_NOTIFY_EXCEPTION)
-		xe_gt_err(gt, "GuC Exception notification\n");
-	else
-		xe_gt_err(gt, "Unknown GuC crash notification: 0x%04X\n", action);
+	return -EHOSTDOWN;
+}
 
+static int guc_handle_exception_msg(struct xe_guc_ct *ct, u32 action)
+{
+	xe_gt_err(ct_to_gt(ct), "GuC Exception notification\n");
 	CT_DEAD(ct, NULL, CRASH);
-
 	kick_reset(ct);
 
-	return 0;
+	return -EHOSTDOWN;
 }
 
 static int parse_g2h_response(struct xe_guc_ct *ct, u32 *msg, u32 len)
@@ -1772,8 +1772,10 @@ static int process_g2h_msg(struct xe_guc_ct *ct, u32 *msg, u32 len)
 		ret = xe_gt_sriov_pf_monitor_process_guc2pf(gt, hxg, hxg_len);
 		break;
 	case XE_GUC_ACTION_NOTIFY_CRASH_DUMP_POSTED:
+		ret = guc_handle_crash_dump_msg(ct, action);
+		break;
 	case XE_GUC_ACTION_NOTIFY_EXCEPTION:
-		ret = guc_crash_process_msg(ct, action);
+		ret = guc_handle_exception_msg(ct, action);
 		break;
 #if IS_ENABLED(CONFIG_DRM_XE_KUNIT_TEST)
 	case XE_GUC_ACTION_TEST_G2G_RECV:
-- 
2.55.0