From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8B44C982CC for ; Sat, 19 Sep 2026 05:01:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8C84610E536; Sat, 19 Sep 2026 05:01:17 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="QjTofpgD"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id 79CE310E65B for ; Sat, 19 Sep 2026 05:01:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1789794064; x=1821330064; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=wUMgD3OARSlZ2JDZbTC0xEC0kWhpkfBvuz25Jm5uSkw=; b=QjTofpgDV70SVxDX+AAA4wUXizbD4RfGDp7Nq9WK6PKZ6H4HWKFLlEpZ y6seD8XiCZNu0MXOUvnEMsH5wwqkyPhgXpuqeDb7fuCgqCKmxHGRCmTmt EZVqqLYAUwlz6f6o/dMhUfg2J1OG5t9sCD3MUKn30ZIeWFyrCqnF5pPho DMR1RDf0ItievnlYAQpy02ewhdLGbfkMBvmcZYZwvWeSjgTv3yzZT9IqJ UhhsTDGxES9Tuupx/hegL4Uu89CwnQPqnDu2DfTF7XvaXq6F+ItB3mpsq awiqoXnEm6X8C7v4iNCBxlzVt1HO8g1yODoJN8Ymfzl+FYnumgUoNhHdw g==; X-CSE-ConnectionGUID: CQT+2K8IS/SVwtFxBVzaIQ== X-CSE-MsgGUID: TzG6l7QkTh2mgSJHIl6UQA== X-IronPort-AV: E=McAfee;i="6800,10657,11909"; a="89463554" X-IronPort-AV: E=Sophos;i="6.27,109,1787036400"; d="scan'208";a="89463554" Received: from fmviesa011.fm.intel.com ([10.60.135.151]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2026 22:01:04 -0700 X-CSE-ConnectionGUID: QKBL8GdHS5WLqLnUhIqgQw== X-CSE-MsgGUID: C/y9hiQ2TlG0C+xgYngJqw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,109,1787036400"; d="scan'208";a="2926720" Received: from orsosgc001.jf.intel.com ([10.54.56.63]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2026 22:01:04 -0700 From: Umesh Nerlige Ramappa To: intel-xe@lists.freedesktop.org Cc: daniele.ceraolospurio@intel.com, michal.wajdeczko@intel.com, aravind.iddamsetty@intel.com, mallesh.koujalagi@intel.com, alan.previn.teres.alexis@intel.com, julia.filipchuk@intel.com Subject: [PATCH v5 7/7] drm/xe/guc: Report errors that cause a CT shutdown using SIGID Date: Fri, 18 Sep 2026 22:01:03 -0700 Message-ID: <20260919050055.2092579-16-umesh.nerlige.ramappa@intel.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260919050055.2092579-9-umesh.nerlige.ramappa@intel.com> References: <20260919050055.2092579-9-umesh.nerlige.ramappa@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" From: Daniele Ceraolo Spurio Convert any errors that can cause the CT to be declared as dead to use the xe_log_err() helper. Errors that are escalated to the callers are left for the caller to report with SIGID if needed. While at it, update some of the error messages to make what went wrong clearer. Signed-off-by: Daniele Ceraolo Spurio Signed-off-by: Umesh Nerlige Ramappa Assisted-by: Claude:claude-opus-5 --- v2: - Use different error codes and better messages (Michal) v3: - Drop GuC from log messages (Michal) - Clean up log messages v4: (Michal) - Add s-o-b and move revision history to end - s/EPROTO/EINVAL/ or FAST_REQ H2G fence failure v5: (Sashiko) - Return correct error in parse_g2h_response and parse_g2h_msg - User xe_log_err in crash and exception handlers --- drivers/gpu/drm/xe/xe_guc_ct.c | 71 +++++++++++++++++++--------------- 1 file changed, 40 insertions(+), 31 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_guc_ct.c b/drivers/gpu/drm/xe/xe_guc_ct.c index 572a52773c56..90f689d71471 100644 --- a/drivers/gpu/drm/xe/xe_guc_ct.c +++ b/drivers/gpu/drm/xe/xe_guc_ct.c @@ -30,6 +30,7 @@ #include "xe_guc_relay.h" #include "xe_guc_submit.h" #include "xe_guc_tlb_inval.h" +#include "xe_log.h" #include "xe_map.h" #include "xe_page_reclaim.h" #include "xe_pm.h" @@ -737,7 +738,7 @@ static int __xe_guc_ct_start(struct xe_guc_ct *ct, bool needs_register) return 0; err_out: - xe_gt_err(gt, "Failed to enable GuC CT (%pe)\n", ERR_PTR(err)); + xe_log_err(gt, GUC, err, "CT: Failed to enable\n"); CT_DEAD(ct, NULL, SETUP); return err; @@ -861,8 +862,9 @@ static bool h2g_has_room(struct xe_guc_ct *ct, u32 cmd_len) desc_write(xe, h2g, status, desc_status | GUC_CTB_STATUS_OVERFLOW); - xe_gt_err(ct_to_gt(ct), "CT: invalid head offset %u >= %u)\n", - h2g->info.head, h2g->info.size); + xe_log_err(ct_to_gt(ct), GUC, -EPIPE, + "CT: invalid head offset %u >= %u)\n", + h2g->info.head, h2g->info.size); CT_DEAD(ct, h2g, H2G_HAS_ROOM); return false; } @@ -931,12 +933,13 @@ static void __g2h_release_space(struct xe_guc_ct *ct, u32 g2h_len) bad |= !ct->g2h_outstanding; if (bad) { - xe_gt_err(ct_to_gt(ct), "Invalid G2H release: %d + %d vs %d - %d -> %d vs %d, outstanding = %d!\n", - ct->ctbs.g2h.info.space, g2h_len, - ct->ctbs.g2h.info.size, ct->ctbs.g2h.info.resv_space, - ct->ctbs.g2h.info.space + g2h_len, - ct->ctbs.g2h.info.size - ct->ctbs.g2h.info.resv_space, - ct->g2h_outstanding); + xe_log_err(ct_to_gt(ct), GUC, -ETOOMANYREFS, + "CT: Invalid G2H release: %d + %d vs %d - %d -> %d vs %d, outstanding = %d!\n", + ct->ctbs.g2h.info.space, g2h_len, + ct->ctbs.g2h.info.size, ct->ctbs.g2h.info.resv_space, + ct->ctbs.g2h.info.space + g2h_len, + ct->ctbs.g2h.info.size - ct->ctbs.g2h.info.resv_space, + ct->g2h_outstanding); CT_DEAD(ct, &ct->ctbs.g2h, G2H_RELEASE); return; } @@ -1004,7 +1007,7 @@ static int ct_corrupted(struct xe_guc_ct *ct, struct guc_ctb *ctb, va_start(va_args, msg); vaf.fmt = msg; vaf.va = &va_args; - xe_gt_err(ct_to_gt(ct), "GUC: CT: %pV", &vaf); + xe_log_err(ct_to_gt(ct), GUC, err, "CT: %pV", &vaf); va_end(va_args); ct_dead_capture(ct, ctb, reason_code); @@ -1290,7 +1293,7 @@ static int guc_ct_send_locked(struct xe_guc_ct *ct, const u32 *action, u32 len, return ret; broken: - xe_gt_err(gt, "No forward progress on H2G\n"); + xe_log_err(gt, GUC, -EDEADLK, "CT: No forward progress on H2G\n"); CT_DEAD(ct, &ct->ctbs.h2g, DEADLOCK); return -EDEADLK; @@ -1625,7 +1628,7 @@ static int parse_g2h_event(struct xe_guc_ct *ct, u32 *msg, u32 len) static int guc_handle_crash_dump_msg(struct xe_guc_ct *ct, u32 action) { - xe_gt_err(ct_to_gt(ct), "GuC Crash dump notification\n"); + xe_log_err(ct_to_gt(ct), GUC, -EHOSTDOWN, "Crash dump notification\n"); CT_DEAD(ct, NULL, CRASH); kick_reset(ct); @@ -1634,7 +1637,7 @@ static int guc_handle_crash_dump_msg(struct xe_guc_ct *ct, u32 action) static int guc_handle_exception_msg(struct xe_guc_ct *ct, u32 action) { - xe_gt_err(ct_to_gt(ct), "GuC Exception notification\n"); + xe_log_err(ct_to_gt(ct), GUC, -EHOSTDOWN, "GuC Exception notification\n"); CT_DEAD(ct, NULL, CRASH); kick_reset(ct); @@ -1661,14 +1664,21 @@ static int parse_g2h_response(struct xe_guc_ct *ct, u32 *msg, u32 len) * failure to trigger a reset. */ if (fence & CT_SEQNO_UNTRACKED) { - if (type == GUC_HXG_TYPE_RESPONSE_FAILURE) - xe_gt_err(gt, "FAST_REQ H2G fence 0x%x failed! e=0x%x, h=%u\n", - fence, - FIELD_GET(GUC_HXG_FAILURE_MSG_0_ERROR, hxg[0]), - FIELD_GET(GUC_HXG_FAILURE_MSG_0_HINT, hxg[0])); - else - xe_gt_err(gt, "unexpected response %u for FAST_REQ H2G fence 0x%x!\n", - type, fence); + int err; + + if (type == GUC_HXG_TYPE_RESPONSE_FAILURE) { + err = -EINVAL; + xe_log_err(gt, GUC, err, + "CT: FAST_REQ H2G fence 0x%x failed! e=0x%x, h=%u\n", + fence, + FIELD_GET(GUC_HXG_FAILURE_MSG_0_ERROR, hxg[0]), + FIELD_GET(GUC_HXG_FAILURE_MSG_0_HINT, hxg[0])); + } else { + err = -EPROTO; + xe_log_err(gt, GUC, err, + "CT: unexpected response %u for FAST_REQ H2G fence 0x%x!\n", + type, fence); + } fast_req_report(ct, fence); @@ -1678,7 +1688,7 @@ static int parse_g2h_response(struct xe_guc_ct *ct, u32 *msg, u32 len) CT_DEAD(ct, NULL, PARSE_G2H_RESPONSE); - return -EPROTO; + return err; } /* don't erase as we still expect a final response with the same fence */ @@ -1744,10 +1754,11 @@ static int parse_g2h_msg(struct xe_guc_ct *ct, u32 *msg, u32 len) origin = FIELD_GET(GUC_HXG_MSG_0_ORIGIN, hxg[0]); if (unlikely(origin != GUC_HXG_ORIGIN_GUC)) { - xe_gt_err(gt, "Invalid G2H origin=%u\n", origin); + int err = -EBADMSG; + xe_log_err(gt, GUC, err, "CT: Invalid G2H origin=%u\n", origin); CT_DEAD(ct, &ct->ctbs.g2h, PARSE_G2H_ORIGIN); - return -EPROTO; + return err; } type = FIELD_GET(GUC_HXG_MSG_0_TYPE, hxg[0]); @@ -1762,7 +1773,7 @@ static int parse_g2h_msg(struct xe_guc_ct *ct, u32 *msg, u32 len) ret = parse_g2h_response(ct, msg, len); break; default: - xe_gt_err(gt, "Unexpected G2H message type=%u\n", type); + xe_log_err(gt, GUC, -EOPNOTSUPP, "CT: Unexpected G2H message type %u\n", type); CT_DEAD(ct, &ct->ctbs.g2h, PARSE_G2H_TYPE); ret = -EOPNOTSUPP; @@ -1862,8 +1873,8 @@ static int process_g2h_msg(struct xe_guc_ct *ct, u32 *msg, u32 len) } if (ret) { - xe_gt_err(gt, "G2H action %#04x failed (%pe) len %u msg %*ph\n", - action, ERR_PTR(ret), hxg_len, (int)sizeof(u32) * hxg_len, hxg); + xe_log_err(gt, GUC, ret, "CT: G2H action %#04x failed len %u msg %*ph\n", + action, hxg_len, (int)sizeof(u32) * hxg_len, hxg); CT_DEAD(ct, NULL, PROCESS_FAILED); } @@ -2046,8 +2057,7 @@ static void g2h_fast_path(struct xe_guc_ct *ct, u32 *msg, u32 len) } if (ret) { - xe_gt_err(gt, "G2H action 0x%04x failed (%pe)\n", - action, ERR_PTR(ret)); + xe_log_err(gt, GUC, ret, "CT: G2H action 0x%04x failed\n", action); CT_DEAD(ct, NULL, FAST_G2H); } } @@ -2166,8 +2176,7 @@ static void receive_g2h(struct xe_guc_ct *ct) mutex_unlock(&ct->lock); if (unlikely(ret < 0 && g2h_err_is_fatal(ret))) { - xe_gt_err(ct_to_gt(ct), "CT dequeue failed, forcing GT reset(%pe)\n", - ERR_PTR(ret)); + xe_log_err(ct_to_gt(ct), GUC, ret, "CT: dequeue failed, forcing GT reset\n"); CT_DEAD(ct, NULL, G2H_RECV); kick_reset(ct); } -- 2.55.0